Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time sound output #89

Open
larsbrinkhoff opened this issue Mar 21, 2016 · 5 comments
Open

Real-time sound output #89

larsbrinkhoff opened this issue Mar 21, 2016 · 5 comments

Comments

@larsbrinkhoff
Copy link
Member

The sound output is oh-so-close to being ok. I guess there are occasional gaps between audio buffer refills.

I don't know how to fix this, but it can't be rocket science.

@stefanberndtsson
Copy link
Member

The current SDL audio output is mostly a hack on top of the previous file output. There is no real coordination between sample generation and sample output, it's just mostly right. Not sure about the state just yet.

@stefanberndtsson
Copy link
Member

I removed some crap now. The buffer was previously filled with anything that happened to be in the generated samples array, regardless of whether or not it was generated this pass through the loop or not. The output stream now copies only as much as has been generated, and fills the rest with zeroes. It sounds somewhat better with -V -A now, but still far from perfect.

@larsbrinkhoff
Copy link
Member Author

I'm thinking -A should either:

  • imply -V, or something to that effect.
  • scale the sound to match the speed of the emulator.

@stefanberndtsson
Copy link
Member

Imply -V, definitely. Should it also prevent respeeding (since -V is no longer a locked feature)?

@larsbrinkhoff
Copy link
Member Author

I say, let the users get what they deserve! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants