Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Investigate Schedule Interaction With Validation & Test Data #27

Open
nmichlo opened this issue Feb 6, 2022 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request proposal Discussion on a new proposed feature
Milestone

Comments

@nmichlo
Copy link
Owner

nmichlo commented Feb 6, 2022

Describe the bug
Schedules may unintentionally be affected by the use of validation and test data enabled in release v0.3.4 5695747

  • These steps might increment trainer.global_step

Conversely validation and test steps will use the current value of the schedule.

  • This should probably instead be the original value in the config

This issue is in response to the fixes introduced in #22

Expected behaviour
I am not sure what the expected behaviour should be in some cases. Further discussion may be required.

  • The framework may need to check if a schedule wants its value to be used or a default value for the validation and test steps, this functionality should possibly be configurable.
@nmichlo nmichlo added bug Something isn't working enhancement New feature or request proposal Discussion on a new proposed feature labels Feb 6, 2022
@nmichlo nmichlo added this to the roadmap milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request proposal Discussion on a new proposed feature
Projects
None yet
Development

No branches or pull requests

1 participant