Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise Loss Reduction Modes #18

Open
nmichlo opened this issue Jul 28, 2021 · 1 comment
Open

Standardise Loss Reduction Modes #18

nmichlo opened this issue Jul 28, 2021 · 1 comment
Labels
breaking change Changes the alter the API or output of code cleanup Changes that only make the code cleaner, not how it works or the output proposal Discussion on a new proposed feature
Milestone
roadmap

Comments

@nmichlo
Copy link
Owner

nmichlo commented Jul 28, 2021 •
edited

Removed reduction="sum" in #12, but considerable effort is still required to maintain and verify models (#3, #4, #5)

Two options exist:

  1. Allow models to specify their allowed modes: "mean" or "mean_sum"
  2. Only use "mean_sum"
@nmichlo nmichlo added cleanup Changes that only make the code cleaner, not how it works or the output proposal Discussion on a new proposed feature breaking change Changes the alter the API or output of code labels Jul 28, 2021
@nmichlo nmichlo added this to the v0.2.0 milestone Jul 28, 2021
@nmichlo nmichlo changed the title [CHANGE]: Remove Loss Reduction Modes Remove Loss Reduction Modes Aug 6, 2021
@nmichlo
Copy link
Owner Author

nmichlo commented Feb 5, 2022

"Loss reduction mode" should maybe be called "beta scaling" and be a boolean value?

  • This takes inspiration from the original BetaVAE paper if I am not mistaken.

The problem with the loss reduction modes is that not all the frameworks supports them.

  • Could this automatically be handled by changing how the loss is aggregated?

@nmichlo nmichlo changed the title Remove Loss Reduction Modes Standardise Loss Reduction Modes Feb 5, 2022
@nmichlo nmichlo assigned nmichlo and unassigned nmichlo Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Changes the alter the API or output of code cleanup Changes that only make the code cleaner, not how it works or the output proposal Discussion on a new proposed feature
Projects
None yet
Milestone
roadmap
Development

No branches or pull requests
1 participant
@nmichlo