Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.0-alpha.4 missing WASM MIME type #1892

Open
timoschwarzer opened this issue Nov 20, 2022 · 4 comments
Open

3.0.0-alpha.4 missing WASM MIME type #1892

timoschwarzer opened this issue Nov 20, 2022 · 4 comments

Comments

@timoschwarzer
Copy link

Describe the bug
The 3.0.0-alpha.4 release on npm is missing the MIME mapping between the .wasm extension and the application/wasm MIME type in createProtocol.js.

Unfortunately I can't make a PR because I didn't find any branch that matches that npm release 🤔
@MatthijsBurgh
Copy link
Collaborator

I have no clue what the changes in alpha 4 is compared to alpha 3. @nklayman worked on it. When you provide a PR based on the V3 branch. I will merge it. And ask @nklayman to release it.

@timoschwarzer
Copy link
Author

In beta 4 the createProtocol.js looks different from what is in the v3 branch. It has way more MIME types in beta.4 than on v3.

@MatthijsBurgh
Copy link
Collaborator

Maybe @nklayman has that commit somewhere on his machine. It is not on GitHub.

@timoschwarzer
Copy link
Author

If you could push that to GitHub @nklayman that would be awesome! I don't want to cause merge conflicts by pushing the changes you already have locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timoschwarzer @MatthijsBurgh