Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.0 #70

Merged
merged 7 commits into from
May 27, 2024
Merged

Release 0.1.0 #70

merged 7 commits into from
May 27, 2024

Conversation

njtierney
Copy link
Owner

Resolves #68

@Aariq
Copy link
Collaborator

Aariq commented May 15, 2024

Weird that crew workers are failing on ubuntu with devel R only. I can try to spin up a docker container and test this out interactively (e.g. set up the crew controller to save out logs)

@Aariq
Copy link
Collaborator

Aariq commented May 15, 2024

I couldn't reproduce the error on r-devel with rocker/geospatial:devel. However, I got a different test error from that container:

Error (test-tar-terra.R:62:5): tar_terra_vect() works
<tar_condition_run/tar_condition_targets/rlang_error/error/condition>
Error: Error running targets::tar_make()
Error messages: targets::tar_meta(fields = error, complete_only = TRUE)
Debugging guide: https://books.ropensci.org/targets/debugging.html
How to ask for help: https://books.ropensci.org/targets/help.html
Last error message:
    the write() function in tar_format() must not create a directory. Found directories inside the data store where there should only be files: _targets/objects/test_terra_vect_shz

I wonder if this has something to do with differences in GDAL versions? terra::gdal() reports "3.0.4" on this container.

@njtierney
Copy link
Owner Author

That is a bit strange re the crew workers! Thanks for checking that out in a docker container.

3.0.4 is 4 years old, it makes me think that maybe we should set a minimum version GDAL version in the DESCRPTION under SystemReqs and then also maybe manage that in GH actions, where we can provide a range of GDAL versions

@brownag
Copy link
Contributor

brownag commented May 15, 2024

I wonder if this has something to do with differences in GDAL versions? terra::gdal() reports "3.0.4" on this container.

Can confirm writing SOZip shapefile requires GDAL >= 3.7. Not sure if we should have a fallback to using utils::zip() (non-SOZip) in this case, or whether it should be an error/test should be skipped on old GDAL

@Aariq
Copy link
Collaborator

Aariq commented May 15, 2024

Still looking into the error with the crew containers. I'm going to see if I can set up the controller to save worker logs in a way that'll be accessible as an artifact from GitHub actions—that should be useful going forward.

GDAL 3.7 was released only about a year ago, so it seems maybe not ideal to require >= 3.7, so it might be a good idea to fallback to utils::zip() with older versions. I can open an issue to discuss this.

@Aariq
Copy link
Collaborator

Aariq commented May 15, 2024

Hmm, I'm stumped. Nothing should have changed with those crew tests in this PR! It's hard to debug because targets::tar_test() does too good of a job isolating things and I can't figure out how to print the crew worker logs on GitHub actions.

@Aariq
Copy link
Collaborator

Aariq commented May 17, 2024

Well, looks like whatever was going on was a temporary GitHub issue.

@njtierney njtierney marked this pull request as ready for review May 27, 2024 07:05
@njtierney njtierney merged commit 290d106 into master May 27, 2024
7 checks passed
@njtierney njtierney deleted the release-010-68 branch May 27, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release geotargets 0.1.0
3 participants