Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for replacement of vscode variables #749

Conversation

seanmlyons22
Copy link

@seanmlyons22 seanmlyons22 commented Apr 24, 2021

Convert Variables such as ${workspaceFolder} so
they can be understood by LLVM

Close #741

Variables such as ${workspaceFolder} can be converted so
they can be understood by LLVM
@niosus
Copy link
Owner

niosus commented Apr 26, 2021

@seanmlyons22 thanks for the contribution. I might be missing a point a bit though. This is already done by using other variables. For example ${project_base_path} will expand to a full path to the project root. How would this variable be different?

@seanmlyons22
Copy link
Author

seanmlyons22 commented May 18, 2021

@niosus, sorry this got lost in my inbox. This would be exactly the same as the other variables. I will update this to be replaced in the same manner.

Edit: Looked at project_base_path, the difference between that variable and ${workspaceFolder} is that the latter is a VSCode variable, so it should only be replaced for c_cpp_properties.json, not for the others.

@niosus
Copy link
Owner

niosus commented May 18, 2021

Got it. Makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

c_cpp_properties.json: Support ${workspaceFolder} substitution
3 participants