fixes #23513, parseutils.nim: parseInt's doc example. #23561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its doc used to render wrongly where `>` is considered as quote block.
Also, the old `runnableExample` is just a copy of `proc parseInt(openArray[char], var int, int)` variant (in Line 1000).
ringabout
reviewed
May 9, 2024
Comment on lines
+477
to
+478
| doAssert parseInt("-2024_05_02", res) == 11 | ||
| doAssert res == -20240502 |
There was a problem hiding this comment.
You also need to add doc comments that parseInt in parseutils and strutils accept signs and underscores
Mentioned in here I think we shall either:
Footnotes
|
for parseInt/BiggestInt(string,...)
Currently I've added examples for all |
|
ping @ringabout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23513
Also, the old
runnableExampleis just a copy ofproc parseInt(openArray[char], var int, int)variant (in Line 1000).