Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An exception might exist after an except clause #18070

Open
alaviss opened this issue May 23, 2021 · 0 comments · May be fixed by #22502 or #23391
Open

An exception might exist after an except clause #18070

alaviss opened this issue May 23, 2021 · 0 comments · May be fixed by #22502 or #23391
Assignees
@ringabout
Labels
Garbage Collection

Comments

@alaviss
Copy link
Collaborator

alaviss commented May 23, 2021 •
edited

An effect of this is that the exception will be logically "leaked" for the remainder of the program.

Reproducible with both exceptions:goto and exceptions:setjmp. Not reproducible with cpp exceptions.

Example

proc main() =
  try:
    try:
      raise newException(CatchableError, "something")
    except:
      raise newException(CatchableError, "something else")
  except:
    doAssert getCurrentExceptionMsg() == "something else"

  let msg = getCurrentExceptionMsg()
  doAssert msg == "", "expected empty string but got: " & $msg

main()

Current Output

in.nim(13)     in
in.nim(11)     main
assertions.nim(30) failedAssertImpl
assertions.nim(23) raiseAssert
fatal.nim(49) sysFatal
Error: unhandled exception: in.nim(11, 12) `msg == ""` expected empty string but got: something [AssertionDefect]

Expected Output

Successfully run

Additional Information

Found while evaluating exceptions semantics for implementation in CPS

$ nim -v
Nim Compiler Version 1.5.1 [Linux: amd64]
Compiled at 2021-05-23
Copyright (c) 2006-2021 by Andreas Rumpf

git hash: 61630c6aee56acf688c48c00f5a6711a59e79616
active boot switches: -d:release -d:nimUseLinenoise
@alaviss alaviss mentioned this issue May 24, 2021
Merged
@ringabout ringabout mentioned this issue Aug 18, 2023
Open
@ringabout ringabout self-assigned this Aug 18, 2023
@ringabout ringabout linked a pull request Aug 21, 2023 that will close this issue
Draft
ringabout added a commit that referenced this issue Aug 21, 2023
@ringabout
add a test for #18070
f5b35ea
bung87 added a commit to bung87/Nim that referenced this issue Aug 23, 2023
@bung87
fixes nim-lang#18070;fixes memory leak with nested Exceptions
7b15a84
ringabout added a commit that referenced this issue Mar 11, 2024
@ringabout
fixes #18070; An exception might exist after an except clause
811ac32
@ringabout ringabout linked a pull request Mar 11, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ringabout ringabout

Labels
Garbage Collection
Projects
None yet
Milestone
No milestone
2 participants
@alaviss @ringabout