Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom schemes are not allowed to be used as redirectTo values #439

Closed
spakanati opened this issue Nov 11, 2023 · 3 comments
Closed

Custom schemes are not allowed to be used as redirectTo values #439

spakanati opened this issue Nov 11, 2023 · 3 comments

Comments

@spakanati
Copy link

spakanati commented Nov 11, 2023

It is possible to add "myapp://host" to allowed URLs but then when trying to use the custom scheme as a redirectTo, you get The+value+of+%22redirectTo%22+is+not+allowed.

I assume this is not expected behavior, since using custom schemes is the recommended way in the nhost-dart example to complete sign in with oauth providers.

I added an example failing test here.

I did a bit of digging and I think the failure happens here because valueUrl.origin is null for custom schemes.

Copy link

stale bot commented May 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 12, 2024
@dbarrosop
Copy link
Contributor

dbarrosop commented May 13, 2024

Good timing to get a remind for this one... Will be fixed by #513

@stale stale bot removed the stale label May 13, 2024
@dbarrosop
Copy link
Contributor

This should be supported now on 0.30.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants