Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom ping message option to Ping function #441

Open
alisonmshu opened this issue Mar 18, 2024 · 1 comment
Open

Add custom ping message option to Ping function #441

alisonmshu opened this issue Mar 18, 2024 · 1 comment

Comments

@alisonmshu
Copy link

alisonmshu commented Mar 18, 2024

func (c *Conn) Ping(ctx context.Context) error {
	p := atomic.AddInt32(&c.pingCounter, 1)

	err := c.ping(ctx, strconv.Itoa(int(p)))
	if err != nil {
		return fmt.Errorf("failed to ping: %w", err)
	}
	return nil
}

func (c *Conn) ping(ctx context.Context, p string) error {

Is it possible to add a parameter to use custom ping/pong message when sending it? Sometimes, one side want to listen to specific ping/pong message. If we can add that, it would be very helpful.
I really like this project. It is simple enough that I can just focus my project logic.

@nhooyr
Copy link
Owner

nhooyr commented Apr 5, 2024

Perhaps, let me think about this. I don't want to expand the API too much but I have some ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants