Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable buffer sizes #422

Open
sermojohn opened this issue Nov 19, 2023 · 1 comment
Open

Configurable buffer sizes #422

sermojohn opened this issue Nov 19, 2023 · 1 comment

Comments

@sermojohn
Copy link

Which is the suggested way to configure this library for high throughput connection, eg 10Mbit or more?

My understanding from navigating the code is that there is no way to configure the read/write buffer size. Do you think this could be a useful addition to the library?
Also increasing the read buffer size should probably be combined with increasing the client OS socket read buffer to prevent overload, which usually results to automatic closing of the connection.

Any feedback on this would be very useful for my use case. Also I am available to work on an enhancement to this library to support high throughput.

@nhooyr nhooyr changed the title Configure websocket client for high throughput Configurable buffer sizes Nov 19, 2023
@nhooyr
Copy link
Owner

nhooyr commented Nov 19, 2023

No current support to configure buffer sizes but I'm not against adding it. Don't have any recommendations. If you don't have benchmarks, I wouldn't modify anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants