New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export wstest #340

Open

Himani-relan opened this issue May 16, 2022 · 1 comment

Labels

Milestone

Himani-relan commented May 16, 2022 •

edited

Pipe function here: https://github.com/nhooyr/websocket/blob/master/internal/test/wstest/pipe.go#L17 is inside the internal package which means it can't be imported by other projects.
However it should be external so that it can be imported by other projects. This could help in unit testing of the projects

Himani-relan changed the title ~~Pipe function shouldn't inside internal package~~ Pipe function shouldn

Himani-relan changed the title ~~Pipe function shouldn~~ Pipe function shouldn't be internal to the project

Owner

nhooyr commented Mar 5, 2023

I figured you'd always want to use httptest instead to setup two real websockets. But I suppose this can be released under a wstest package.

nhooyr changed the title ~~Pipe function shouldn't be internal to the project~~ export wstest

nhooyr added the enhancement label

nhooyr added this to the v1.9.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment