-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
untracked for all methods? #4268
Comments
What if we move the |
Would this be a breaking change? |
If I write code that relies on the runtime error being thrown, it could be a breaking change. But I see it is extremely rare to have such code... In the best case, we can tell developers they can now remove their ATM, I tend to say it is an "acceptable breaking change". |
I tried it out, and some tests failed. I have to verify what kind of nature those failures are. Maybe that change has some implications which might be breaking... |
Which @ngrx/* package(s) are relevant/related to the feature request?
signals
Information
Angular is starting to untrack certain things by default:
angular/angular#54614
Since 17.1.1, Signal Store does the same for rxMethods. Should we also consider this for all other methods provided by the Signal Store? Normally, I don't want such Methods to get the caller's reactive context.
Describe any alternatives/workarounds you're currently using
a) Calling untracked by hand
b) Using toObservable (which does the same as a) underneath the covers)
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: