Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Skeleton loading #1236

Open
2 of 5 tasks
tamalCodes opened this issue Mar 12, 2024 · 2 comments · May be fixed by #1241
Open
2 of 5 tasks

Feature: Skeleton loading #1236

tamalCodes opened this issue Mar 12, 2024 · 2 comments · May be fixed by #1241
Labels
💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project.

Comments

@tamalCodes
Copy link
Member

Description

  • Because of Internet connection constraints the data might load at a certain delayed amount for different users and we do not have any loading animation for the same
  • As you can see from the screenshot section down below you will notice that for clubs the images take time to load as a result there is an almost empty screen for events because the whole events are compiled as one single section it takes some time to load too
  • The point is we need to have some kind of loading states or loading transition or animation available globally such that it matches our theme and we reuse it everywhere

Proposed Solution

image

We also need a skeleton animation for example vercel has their skeleton animation you can take inspiration from these and maybe build something very similar to it

Screenshots

image
image

🥦 Browser

Google Chrome

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am participating in JWOC
  • I am participating in IWOC
  • I am willing to work on this issue (blank for no)
@tamalCodes tamalCodes added 💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Mar 12, 2024
@github-actions GitHub Actions
Copy link

Hello @tamalCodes, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@Piyush-linux
Copy link

Piyush-linux commented Mar 14, 2024 •
edited

Working on this one 💚 ,

found this error @tamalCodes

Screenshot_2024-03-16-17-44-39_1920x1080

@Piyush-linux Piyush-linux linked a pull request Mar 18, 2024 that will close this issue
Open
Piyush-linux added a commit to Piyush-linux/Milan that referenced this issue Mar 30, 2024
@Piyush-linux
Merge branch 'milancommunity:main' into feat-ngoworldcommunity#1236/s…
3252902 
…keleton-loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project.
Projects
Milan
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: skeleton loading Piyush-linux/Milan
2 participants
@tamalCodes @Piyush-linux