Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Revamping Join us section in Home page #1216

Open
3 of 5 tasks
Radhikarathi04 opened this issue Feb 15, 2024 · 11 comments · May be fixed by #1238
Open
3 of 5 tasks

Bug: Revamping Join us section in Home page #1216

Radhikarathi04 opened this issue Feb 15, 2024 · 11 comments · May be fixed by #1238
Assignees
@Radhikarathi04
Labels
🐞 bug This is a patch, generally fixing some bugs. invite me to the organisation Sends an invitation to your community organisation. status: discuss 💬 Currently we are discussing about the further proceedings of the PR/issue.

Comments

@Radhikarathi04
Copy link

Description

There's an inconsistency in the spacing between the exclamation mark and the preceding word in the heading "Join us, right away!" - an extra space is present, which deviates from the standard formatting.

Proposed Solution

remove the extra space between the exclamation mark and the word "away" in the heading "Join us, right away!" to maintain consistency with the rest of the headings.

Screenshots

Screenshot 2024-02-15 at 16 05 40

Browser 🥦

Google Chrome

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am participating in JWOC
  • I am participating in IWOC
  • I am willing to work on this issue (blank for no).
@Radhikarathi04 Radhikarathi04 added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Feb 15, 2024
@github-actions GitHub Actions
Copy link

Hello @Radhikarathi04, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@tamalCodes
Copy link
Member

Hey, that is an amazing spot however we are revamping this section in terms of design as well. so it all might change. Would you be interested in contributing to the same?

This is the card that we have in mind as of now and the design might change later on

image

@tamalCodes tamalCodes added status: discuss 💬 Currently we are discussing about the further proceedings of the PR/issue. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Feb 16, 2024
@Radhikarathi04
Copy link
Author

Sure, I would like to work on it

@Radhikarathi04
Copy link
Author

Can we have a detailed chat about this revamp of design, before I start working on it 😊

@tamalCodes
Copy link
Member

Hi yeah, do ask whatever you find difficult. Here is the Figma file for the same design

@KrishVrm KrishVrm mentioned this issue Feb 22, 2024
Closed
@tamalCodes
Copy link
Member

Let's catch up 🙋🏻‍♂️

Hi @Radhikarathi04 , it has been a while since we last had a conversation so I wanted to know if you are still working on this. Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at [email protected]

@Radhikarathi04
Copy link
Author

Radhikarathi04 commented Mar 4, 2024 via email •
edited

@Radhikarathi04
Copy link
Author

Hi Tamal, please let me know when we can catch up, would love to work on this 👍

@Charan2409
Copy link

Hi @tamalCodes I would like to contribute here as well , could you please give more details on this ?

@tamalCodes tamalCodes changed the title Bug: typo in home screen Bug: Revamping Join us section in Home page Mar 12, 2024
@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Mar 12, 2024
@github-actions GitHub Actions
Copy link

Hi @tamalCodes, We just made a new organization, and have sent you an invite. Welcome to the community 🎉

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people

@tamalCodes tamalCodes reopened this Mar 12, 2024
@Radhikarathi04
Copy link
Author

Hi Tamal,

I've begun working on the feature, but when I try to preview the changes I've made using npm run dev, I encounter an issue.

  • [BABEL] Note: The code generator has deoptimised the styling of /Users/Radhika.Rathi/Documents/RR/first_open_source_milan_project/Milan/src/assets/pictures/Banner/MilanBuild.svg as it exceeds the max of 500KB.
    [BABEL] Note: The code generator has deoptimised the styling of /Users/Radhika.Rathi/Documents/RR/first_open_source_milan_project/Milan/src/assets/pictures/Banner/MilanCollaborate.svg as it exceeds the max of 500KB.

@Radhikarathi04 Radhikarathi04 linked a pull request Mar 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radhikarathi04 Radhikarathi04

Labels
🐞 bug This is a patch, generally fixing some bugs. invite me to the organisation Sends an invitation to your community organisation. status: discuss 💬 Currently we are discussing about the further proceedings of the PR/issue.
Projects
Milan
Status: Todo
Milestone
No milestone
3 participants
@tamalCodes @Charan2409 @Radhikarathi04