Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: A new floating header bar #1217

Open
2 of 5 tasks
tamalCodes opened this issue Feb 16, 2024 · 5 comments
Open
2 of 5 tasks

Feature: A new floating header bar #1217

tamalCodes opened this issue Feb 16, 2024 · 5 comments
Assignees
Labels
💡 feature This generally contains addition/changes to features. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@tamalCodes
Copy link
Member

Description

  • It must be responsive for mobiles as well as the desktop version
  • The design can be found below it will be best to follow the design as accurately as possible
  • If needed we can integrate libraries like framework motion to make the animations much smoother else continue with the vanilla css that we are using
    desktop version

Proposed Solution

Check the figma design here and prototype here to see how the animation looks like

Screenshots

image
image

🥦 Browser

Brave

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am participating in JWOC
  • I am participating in IWOC
  • I am willing to work on this issue (blank for no)
@tamalCodes tamalCodes added 💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Feb 16, 2024
Copy link

Hello @tamalCodes, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@riteshshukladev
Copy link

riteshshukladev commented Feb 16, 2024

Hey @tamalCodes, would love to add this animation, kindly assign.

@tamalCodes
Copy link
Member Author

Hi @riteshshukladev , please go ahead with it !

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

@tamalCodes tamalCodes added status: wip 👩🏻‍💻 This issue/PR is actively being worked on. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Feb 16, 2024
@riteshshukladev
Copy link

hey @tamalCodes, need your help ,as i'm facing an weird type of issue like after clonning the codebase and intallling the required dependencies . when i starts the development server and makes some changes in the codebase the changes doesn't get reflected in the UI and in the terminal of my editor.

Rather,it throws an text like this, [BABEL] Note: The code generator has deoptimised the styling of C:\Users\Ritesh\OneDrive\Documents\Milan\src\assets\pictures\Banner\MilanBuild.svg as it exceeds the max of 500KB., (that is actually the build file).

To solve this issue early on i , asked chatGPT why the changes doesn't get reflected in the UI and passed this message as well, it gave me a resposne that , HMR(Hot Module Replacement) that allows developers to see their changes in the browser without needing a full page reload in web development servers, such as Webpack.
The message you're seeing in your command line, regarding Babel deoptimizing the styling of a specific SVG file due to its size exceeding the maximum limit of 500KB, is indeed relevant and could be contributing to the issues you're experiencing. This message indicates that the SVG file is unusually large for a web asset, which might not only affect the build optimization process but could also have implications for hot module replacement (HMR) and the overall performance of your development server.

please help!!

@tamalCodes
Copy link
Member Author

That is not an error, the thing you get from Babel is a warning, everything else should work fine. Can you check the console to see? Also can you give me a screen recording using any free software so that I can see too ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature This generally contains addition/changes to features. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
Status: In Progress (Issues)
Development

Successfully merging a pull request may close this issue.

2 participants