Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shift+Tab should not focus on clear icon #2371

Merged
merged 5 commits into from May 24, 2024

Conversation

oliverguenther
Copy link
Contributor

Closes #2366

@oliverguenther oliverguenther marked this pull request as ready for review May 13, 2024 12:55
@pavankjadda pavankjadda changed the title Shift+Tab should not focus on clear icon fix: Shift+Tab should not focus on clear icon May 23, 2024
@coveralls
Copy link

coveralls commented May 23, 2024

Coverage Status

coverage: 93.935% (+0.008%) from 93.927%
when pulling 034d02f on oliverguenther:fix/2366/backfocus
into 30ff11e on ng-select:master.

@pavankjadda pavankjadda enabled auto-merge (squash) May 23, 2024 19:11
@pavankjadda pavankjadda disabled auto-merge May 23, 2024 19:11
@pavankjadda
Copy link
Collaborator

@oliverguenther can you add test case for this? Then I will be able to merge this.

@pavankjadda pavankjadda enabled auto-merge (squash) May 24, 2024 14:59
@pavankjadda pavankjadda merged commit 54edaad into ng-select:master May 24, 2024
5 checks passed
Copy link

🎉 This PR is included in version 13.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tabIndex backwards not working with clear button
3 participants