Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Differentiate the responsibility between showPreview and showOpenInCodeSandbox #2532

Closed
kuri-sun opened this issue Mar 16, 2024 · 3 comments
Labels
🐛 Type: Bug Something isn't working

Comments

@kuri-sun
Copy link
Member

NextUI Version

2.2.10

Describe the bug

In the CodeDemo component, we have showOpenInCodeSandbox property but showOpenInCodeSandbox is not going to be false unless we set showPreview to false as well.

showOpenInCodeSandbox={showOpenInCodeSandbox || showPreview}

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

showOpenInCodeSandbox={showOpenInCodeSandbox || showPreview}

Expected behavior

If showOpenInCodeSandbox set to false, “Open In Sandbox” button will be hidden.
If showPreview set to false, the preview will be hidden.

Screenshots or Videos

No response

Operating System Version

macOS

Browser

Chrome

@kuri-sun kuri-sun added the 🐛 Type: Bug Something isn't working label Mar 16, 2024
@kuri-sun
Copy link
Member Author

I will work on this! thanks, guyss!

@kuri-sun
Copy link
Member Author

This issue will be taken care of by #2517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant