Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GetHashCode() of the NextcloudClient/Types/ResourceInfo.cs #249

Open
SunboX opened this issue Aug 14, 2017 · 0 comments
Open

Refactor GetHashCode() of the NextcloudClient/Types/ResourceInfo.cs #249

SunboX opened this issue Aug 14, 2017 · 0 comments
Labels
1. to develop enhancement help wanted starter issue
Milestone
Nextcloud App 1.2.0

Comments

@SunboX
Copy link
Member

SunboX commented Aug 14, 2017

The hash code is calculated using dynamic properties. So it will change, for example, if you favourite the object. This is bad practize. See Guideline: the integer returned by GetHashCode should never change here:
https://blogs.msdn.microsoft.com/ericlippert/2011/02/28/guidelines-and-rules-for-gethashcode/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop enhancement help wanted starter issue
Projects
None yet
Milestone
Nextcloud App 1.2.0
Development

No branches or pull requests
1 participant
@SunboX