-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing status is not relayed by version 1.2.4 of the external signaling server #12252
Comments
Or to simply list all types we use? |
As stated in the past, I would prefer you use the transient data feature for the typing indication ;-) Anyway, the problem comes from the fact that the JSON unmarshalling in doesn't trigger an error even though you clearly don't send a Only the Could you please open an issue in the strukturag/nextcloud-spreed-signaling repository? Thanks. |
Fixed in next nextcloud-spreed-signaling version, see strukturag/nextcloud-spreed-signaling#733 Thanks a lot @fancycode ! |
How to use GitHub
Since version 1.2.4 of the external signaling server the
roomType
parameter in signaling messages must be one of the predefined values (audio
,video
orscreen
). If the room type is not valid then the message is discarded without relaying it to the other participants, and an error message is logged; for example:Signaling messages are used to send the
startedTyping
andstoppedTyping
messages to other participants, either when the typing status changes or when a participant joins a conversation. As those signaling messages are unrelated to calls noroomType
was included, so now those messages fail with the external signaling server 1.2.4.I am not sure if it would be better to just set the
roomType
tovideo
even if it does not really fit (like already done for signaling messages in calls when there is no peer or when the message refers to the whole participant, like reactions or raised hands), or change the external signaling server code to allow again messages without room types, add another room type for messages unrelated to actual signaling between call peers, or limit the room type validation to messages related to actual signaling between call peers.@fancycode What do you think? Thanks!
The text was updated successfully, but these errors were encountered: