Enable Login v2 #2908
Enable Login v2 #2908
Conversation
Signed-off-by: Milen Pivchev <[email protected]>
Brand/NCBrand.swift
Outdated
| @@ -68,7 +68,7 @@ let userAgent: String = { | |||
| @objc public var use_themingColor: Bool = true | |||
| @objc public var use_themingLogo: Bool = false | |||
| @objc public var use_storeLocalAutoUploadAll: Bool = false | |||
| @objc public var use_loginflowv2: Bool = false // Don't touch me !! | |||
| @objc public var use_loginflowv2: Bool = true // Don't touch me !! | |||
There was a problem hiding this comment.
@marinofaggiana The plan is to use v2 by default from now on, and v1 will be obsolete with removal of oldest supported NC version. Maybe we can remove this? Not sure if the brander will break
There was a problem hiding this comment.
yes I created this switch years ago to test v2
There was a problem hiding this comment.
Is it ok to remove it?
Signed-off-by: Milen Pivchev <[email protected]>
|
Added the option to do the flow via external browser @tobiasKaminsky |
iOSClient/Login/NCLoginWeb.swift
Outdated
| @@ -47,6 +47,9 @@ class NCLoginWeb: UIViewController { | |||
| var loginFlowV2Endpoint = "" | |||
| var loginFlowV2Login = "" | |||
|
|
|||
| // Opens the login URL in external browser instead of in app. User must manually go back to the app. | |||
| let loginFlowv2ExternalBrowser = false | |||
There was a problem hiding this comment.
@marinofaggiana Please test with this enabled and disabled
Signed-off-by: Milen Pivchev <[email protected]>
iOSClient/Login/NCLoginWeb.swift
Outdated
| NextcloudKit.shared.getLoginFlowV2Poll(token: self.loginFlowV2Token, endpoint: self.loginFlowV2Endpoint) { server, loginName, appPassword, _, error in | ||
| if error == .success, let server, let loginName, let appPassword { | ||
| self.createAccount(server: server, username: loginName, password: appPassword) | ||
| } |
There was a problem hiding this comment.
If error write a message and goBack ?
There was a problem hiding this comment.
I stopped using NCLoginWeb for v2 and this screen stopped appearing. Now we only use NCLogin. NCLoginWeb can be renamed to NCLoginProviders as now only external providers use it.
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
|
@marinofaggiana Please check |
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
This enables Login v2. Code was already available
Note: The log in still happens in an in-app browser, IMO this is a better UX. @tobiasKaminsky :
Simulator.Screen.Recording.-.iPhone.15.-.2024-04-30.at.13.40.57.mp4
@marinofaggiana We can remove all v1 code with removal of oldest supported NC version