Disabling fullscreen not works

[adaniello]

If i want hide "fullscreen" icon, eg. via "fullscreen" data attribute by setting it to "false" , i can't.

You can check this issue also in your demo https://nextapps-de.github.io/spotlight/ at the section "Choose Controls (Toolbar)": checkbox not has effect.

Thanks

[mirumirumi]

Yes, I have same problem.
For now, I'm doing this:

.spl-fullscreen {
  display: none !important;
}

[pryley]

@ts-thomas

This is happening because the detect_fullscreen function overrides the control option for fullscreen.

Possibly related to #38

Here is the explanation in the code for that function:

spotlight/src/js/spotlight.js

Lines 650 to 652 in 5160e79

	// handle when user toggles the fullscreen state manually
	// entering the fullscreen state manually needs to be hide the fullscreen icon, because
	// the exit fullscreen handler will not work due to a browser restriction

spotlight/src/js/spotlight.js

Lines 660 to 663 in 5160e79

	function detect_fullscreen(){
	toggleDisplay(maximize, (screen.availHeight - window.innerHeight) > 0);
	}

And if I understood it correctly, something like this should fix the problem (?):

function detect_fullscreen(){
    if ((screen.availHeight - window.innerHeight) <= 0) {
        toggleDisplay(maximize, false);
    }
}

However, possibly a more complete solution would be to instead check the fullscreen control option in this function and only proceed if it's not set as hidden. In that case, perhaps something like this is more suitable:

function detect_fullscreen(){
    if (false !== parse_option("fullscreen", controls_default["fullscreen"])) {
        toggleDisplay(maximize, (screen.availHeight - window.innerHeight) > 0);
    }
}