Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support directives in go.mod #3492

Open
pombredanne opened this issue Aug 19, 2023 · 1 comment · May be fixed by #3693
Open

Support directives in go.mod #3492

pombredanne opened this issue Aug 19, 2023 · 1 comment · May be fixed by #3693

Comments

@shravankshenoy
Copy link

Hey @pombredanne and @AyanSinhaMahapatra, I have raised a PR for the replace directive, but had doubts regardings the best way to approach some of the the things, listed below. Would it be possible to share some suggestions on how to best approach these?

  1. What should be the scope for the original and replaced modules? Would replace be fine for both of them or should one be require and other be replace?

  2. If a package is in both require and replace directives, we will have 2 instances of the same package listed? Is that ok or is there a way to deal with that?
    For example in the go.mod of milvus (added in the PR), packages like github.com/expr-lang/expr and github.com/streamnative/pulsarctl are there both in the require as well in replace directives. This might be a very common scenario, as many a times a go developer might want to test an application with a local version or forked version of a dependency package, rather than using the original package

  3. How do we deal with the replacement package if the replacement points to a local path like replace github.com/milvus-io/milvus/pkg => ./pkg ?
    `

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants