-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractType.unitSize value is a string instead of an int #102
Comments
I agree with this proposition. I will provide a PR. |
Sygus
pushed a commit
that referenced
this issue
Dec 29, 2022
Resolve "doc (dsl) minor fix on Preset class" Closes #102 See merge request ANS015/netzob!287
Sygus
pushed a commit
that referenced
this issue
Dec 30, 2022
Resolve "doc (dsl) minor fix on Preset class" Closes #102 See merge request ANS015/netzob!287
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The available values of AbstractType.unitSize are :
UNITSIZE_1 = '1'
UNITSIZE_4 = '4'
UNITSIZE_8 = '8'
UNITSIZE_16 = '16'
UNITSIZE_32 = '32'
UNITSIZE_64 = '64'
Why aren't they int values?
UNITSIZE_1 = 1
UNITSIZE_4 = 4
UNITSIZE_8 = 8
UNITSIZE_16 = 16
UNITSIZE_32 = 32
UNITSIZE_64 = 64
Comparing int values is faster than str.
Furthermore, in splitStatic() of Inference/Vocabulary/Format.py the docstring tells that unitSize parameter is an int.
And in RelationFinder._generateDataValues() we can see the conversion from int to str then from str to int to get the good unitSize...
The text was updated successfully, but these errors were encountered: