-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
easyrtc adapter should register local media with clientId instead of local #320
Comments
About the component that uses the |
#299 is related if you want to work on displaying a screen share on a shared plane. You need to handle the ended event on the video track to reset the plane texture to a default image for example, if you create a modified version of networked-video-source, something like this (I didn't test this code, but some parts come from my own app):
screenshareEmptyTexture is defined somewhere with:
|
saw this recently; was curious, does NAF handle this correctly by setting streams to null? |
yes for video networked-aframe/src/components/networked-video-source.js Lines 75 to 77 in 39a9b8f
and for audio I did it in #288 a year ago networked-aframe/src/components/networked-audio-source.js Lines 60 to 62 in ce9c843
|
Currently the easyrtc adapter register the local media streams under the "local" key, see
networked-aframe/src/adapters/EasyRtcAdapter.js
Lines 270 to 287 in 76023a2
I tried to change in this code "local" by
NAF.clientId
but the camera media will be under the empty "" key becauseNAF.clientId
is not populated before setting the camera stream I guess.Note that the
networked-video-source
component doesn't currently support showing local media stream, it's works only for remote participants.This behavior differs from the janus adapter where the local media streams are registered with the
NAF.clientId
key, making it possible to create a component on a shared plane in the room that set a url likenaf://clients/<clientId>/video
(or could benaf://clients/<clientId>/screen
for easyrtc supporting multi streams) and getting the correct media stream with:The easyrtc adapter should be modified to register the local streams with the clientId.
The text was updated successfully, but these errors were encountered: