Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRequest::setCookie does mot match Request::setCookie #200

Open
hanak opened this issue May 14, 2021 · 1 comment
Open

IRequest::setCookie does mot match Request::setCookie #200

hanak opened this issue May 14, 2021 · 1 comment
Milestone

Comments

@hanak
Copy link

hanak commented May 14, 2021

Version: 3.0.5

Bug Description

Parameter $sameSite is missing in IRequest::setCookie. And, name of the parameter $expire (IRequest::setCookie) does not match name of the parameter $time (Request::setCookie).

Steps To Reproduce

Not a runtime error.

Expected Behavior

Both the interface and the implementation should match unless IRequest::setCookie and Request::setCookie are not related.

Possible Solution

Update IRequest::setCookie to match Request::setCookie.

@dakur
Copy link
Contributor

dakur commented Aug 20, 2021

I was just confused by this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants