Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing havingOr ? #240

Open
dakujem opened this issue Nov 16, 2019 · 3 comments · May be fixed by #243
Open

Missing havingOr ? #240

dakujem opened this issue Nov 16, 2019 · 3 comments · May be fixed by #243

Comments

@dakujem
Copy link

dakujem commented Nov 16, 2019

I would like to see method Selection::havingOr implemented, as that feature is missing and cumbersome to achieve.

It should work analogously to the Selection::whereOr method.

Let me know if I could work on this. Also, I'd like to port this feature to the 2.x branch.

@dg
Copy link
Member

dg commented Nov 18, 2019

Yes, please send PR.

@dakujem dakujem linked a pull request Nov 26, 2019 that will close this issue
@dakujem
Copy link
Author

dakujem commented Mar 26, 2020

Well I looked into this issue the other day and found out it would require a deeper rework and a BC break without a doubt.

This is because in the SqlBuilder class, the "where" conditions are represented as an array of conditions, whereas the "having" conditions are represented as a string.

And since I know what the attitude to BC breaks (or general overhauls) is, I'd rather work on it once I know there will be support.

@dg
Copy link
Member

dg commented Mar 26, 2020

Of course, this new feature should not cause a BC break…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants