-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore dist #72
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I recommend git-ignoring the
dist
folder. The files can be generated on first run or with the npmpostinstall
script. As it is, code reviews are noisy (babel and minified code shows up) and there's a bit of a security risk in that one could sneak code into the dist files and most reviewers would not notice.The text was updated successfully, but these errors were encountered: