Sidebar not affected by color theme change

[julianstolp]

Deployment Type

NetBox Cloud

NetBox Version

v4.0-beta1

Python Version

3.10

Steps to Reproduce

1. Click the bulb in the top right corner to toggle the color mode to light mode

Expected Behavior

Sidebar swiches to light mode

Observed Behavior

Sidebar stays dark

The theme is hardcoded to data-bs-theme="dark"

<aside class="navbar navbar-vertical navbar-expand-lg" data-bs-theme="dark">

[jeremystretch]

Yes, this is intentional.

[candlerb]

I'm not sure why this is intentional - IMO the combination looks terrible.

I know that dark mode is the trendy view these days, but I'm used to light mode and my eyes prefer it. Mixed dark/light just looks like a rendering bug.

Secondary issue: the navigation menu no longer collapses. It's not really an issue on a desktop monitor, but on a laptop it significantly reduces the amount of space available for data display.

[jeremystretch]

IMO the combination looks terrible

We'll have to disagree; I quite like it. You'll note it's also the style preferred in Tabler's live demo. But that's the great thing about open source: You're always free to modify the code to your liking.

Secondary issue: the navigation menu no longer collapses. It's not really an issue on a desktop monitor, but on a laptop it significantly reduces the amount of space available for data display.

I don't see any need for it, but #15614 is open for an owner. We'll see if there's any overlap between people who see value in the functionality and people willing to contribute their time and effort implementing it.

[candlerb]

You'll note it's also the style preferred in Tabler's live demo

Can you give a specific location? Do you mean "Layout > Vertical" and/or "Layout > Condensed"? But there are also "Layout > Vertical Transparent" and "Layout > Right Vertical" which use light mode for navigation, at least when the browser is in light mode. I don't see any indication that one is "preferred" over the other.

Cross-ref: FR tabler/tabler#1803 shows examples of both light mode and collapsible navigation.

[jeremystretch]

Can you give a specific location?

Sorry; their demo site uses frames. The combined layout (which is what we use in v4.0) is what I intended to link.