Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not synchronize by default? #627

Open
Thooto opened this issue Sep 9, 2021 · 1 comment
Open

Do not synchronize by default? #627

Thooto opened this issue Sep 9, 2021 · 1 comment

Comments

@Thooto
Copy link

Thooto commented Sep 9, 2021

I'm submitting a...


[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Not explicitely providing the synchronize: false option to the module calls the sequelize.sync() method which can alter a database in unexpected ways.

Expected behavior

Not explicitely providing the synchronize option shouldn't call the sequelize.sync() method.

What is the motivation / use case for changing the behavior?

I believe having the synchronize option enabled by default can be quite unforgiving if forgotten or omitted as this isn't a sequelize default behaviour (you have to explicitely call sequelize.sync()) and would be safer for projects relying on another database syncing mechanism (migrations, etc.).

Also the documentation doesn't appear really clear to me (keeping both original sync option and the new synchronize option).

Thanks for the consideration!

@cojack
Copy link

cojack commented May 29, 2024

It's still related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants