Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss interact and Layout Keys being coupled to LEDs #67

Open
doughsay opened this issue Jul 11, 2020 · 3 comments
Open

Discuss interact and Layout Keys being coupled to LEDs #67

doughsay opened this issue Jul 11, 2020 · 3 comments
Labels
discussion Needs discussion

Comments

@doughsay
Copy link
Member

May overlap with: #43

See comment: #54 (comment)

There was another comment somewhere about not coupling Keys to LEDs and looking up by coords to feed the event to interact. Can't find the comment.

There's also this comment, which might be more about layouts than about interactions, but I feel this is all tied together: #54 (comment)

@doughsay doughsay added the discussion Needs discussion label Jul 11, 2020
@doughsay doughsay mentioned this issue Jul 11, 2020
4 tasks
@amclain
Copy link
Member

amclain commented Jul 12, 2020

Dropping the diagram in here from #54 (comment) of how an event could bridge the gap between keys and LEDs so that the keyboard server doesn't have to know about LEDs and the animation engine doesn't have to know about keys. This would also allow the application to send events to the engine, allowing for software-based events.

layout

@abelino
Copy link

abelino commented Jul 14, 2020

Will Event be capable of handling key hold and key up. These other event types might be useful in much more complex animations such as intensified ripples, where a ripple can increase intensity the more the key is held.

@amclain
Copy link
Member

amclain commented Jul 14, 2020

Will Event be capable of handling key hold and key up.

That's a really interesting idea. If we sent an %Event{}, we could have a :type property that could hold that sort of information. Also to decouple events from the concept of keys, we could support "momentary" and "latching" events, which could have types like (TBD) momentary, on, and off. This could represent key press, key up, key down, as well as a variety of other things with similar behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Needs discussion
Projects
None yet
Development

No branches or pull requests

3 participants