pageserver: use identity file as node is authority and remove init command and config-override flags #7766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible will soon write the node id to `identity.toml` in the work dir for new pageservers. On the pageserver side, we read the node id from the identity file if it is present and use that as the source of truth. If the file is not present, we rely on the node id stored in `pageserver.toml`. This allows us to remove the `pageserver init` step altogether since Ansible was the only user of it. Note that this change and the associated Ansible change should merge roughly at the same time. While only one of them is merged we will not be able to provision new pageservers.
3060 tests run: 2933 passed, 0 failed, 127 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
338bbed at 2024-05-17T09:27:24.534Z :recycle: |
problame
reviewed
May 15, 2024
There was a problem hiding this comment.
Title should mention that we remove the --init mode.
The test test_pageserver_init_node_id will fail because of that.
The removal of --init is a breaking change, so, we might as well get rid of --config-override in this PR as well. (The title should mention that as well)
VladLazar
changed the title
problame
approved these changes
May 16, 2024
|
The |
"newline is not allowed in an inline table"
problame
reviewed
May 17, 2024
problame
approved these changes
May 17, 2024
bayandin
reviewed
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall plan: https://www.notion.so/neondatabase/Rollout-Plan-simplified-pageserver-initialization-f935ae02b225444e8a41130b7d34e4ea?pvs=4
Ansible will soon write the node id to
identity.tomlin the work dir for new pageservers. On the pageserver side, we read the node id from the identity file if it is present and use that as the source of truth. If the file is not present, we rely on the node id stored inpageserver.toml.This PR also removes the
--initmode and the--config-overrideflag from thepageserverbinary.The neon_local is already not using these flags anymore.
Ansible still uses them until the linked change is merged, so, this PR has to land simultaneously or after the Ansible change due to that.
Related ansible change: https://github.com/neondatabase/aws/pull/1322
Cplane change to remove config-override usages: https://github.com/neondatabase/cloud/pull/13417
Closes: #7736
Checklist before requesting a review
Checklist before merging