Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose Menu - top bar not updated after attaching files from file browser #4274

Open
Knusper opened this issue Apr 25, 2024 · 3 comments
Open
Labels

Comments

@Knusper
Copy link

Knusper commented Apr 25, 2024

In the compose menu I decide to add some files as attachment. I press a, enter the path of the directory where my files are, then press <tab> to open the file browser. There I tag the files that I want to attach with t and then I press ; <enter> to have them attached. I am now back in the compose menu, but the top bar still shows the top bar of the file browser, not of the attachment menu. (I noticed, because I miss the part where it says "Appx. message size".

When trying to reproduce this behavior by just attaching a file without going via the file browser, I also noticed that the "Appx. message size" message is not updated properly.

Expected Behaviour

The top bar from the compose menu is shown. The screenshot below shows the situation prior to selecting the attachments

Screenshot_20240425_115633

Actual Behaviour

Still seeing the top bar from the file browser. The screenshot below shows the situation after returning from the file browser tot the compose menu.

Screenshot_20240425_115741

Steps to Reproduce

Given in the general report.

How often does this happen?

  • Always

When did it start to happen?

I just started noticing it today - but I remember that it has been working as expected in older releases.

NeoMutt Version

NeoMutt 20240329
Copyright (C) 2015-2024 Richard Russon and friends
NeoMutt comes with ABSOLUTELY NO WARRANTY; for details type 'neomutt -vv'.
NeoMutt is free software, and you are welcome to redistribute it
under certain conditions; type 'neomutt -vv' for details.

System: Linux 6.5.0-27-generic (x86_64)
ncurses: ncurses 6.3.20211021 (compiled with 6.3.20211021)
GPGME: 1.16.0-unknown
GnuTLS: 3.7.3
libnotmuch: 5.6.0
storage: tokyocabinet

Configure options: --prefix=/home/edmundherenz/local --disable-idn2 --gpgme --lua --notmuch --with-ui --gnutls --tokyocabinet --sqlite --disable-autocrypt

Compilation CFLAGS: -fno-delete-null-pointer-checks -D_ALL_SOURCE=1 -D_GNU_SOURCE=1 -D__EXTENSIONS__ -D_XOPEN_SOURCE_EXTENDED -I/usr/include/lua5.4 -I/home/edmundherenz/local/include -I/home/edmundherenz/local/include -DNCURSES_WIDECHAR -I/home/edmundherenz/local/include -I/usr/include/p11-kit-1 -O2

Compile options:
  -autocrypt +fcntl -flock -fmemopen +futimens +getaddrinfo +gnutls +gpgme 
  -gsasl -gss +hcache -homespool -idn +inotify -locales_hack +lua -mixmaster 
  +nls +notmuch -openssl +pgp +regex -sasl +smime +sqlite +truecolor 

MAILPATH="/var/mail"
PKGDATADIR="/home/edmundherenz/local/share/neomutt"
SENDMAIL="/usr/sbin/sendmail"
SYSCONFDIR="/home/edmundherenz/local/etc"

Extra Info

The only possible relevant bits from my config could be:

# status bar
set status_format="-%r- %f [Msgs:%?M?%M/?%m%?n? New:%n?%?o? Old:%o?%?d? Del:%d?%?F? Flag:%F?%?t? Tag:%t?%?p? Post:%p?%?b? Size: %l?]---(%s/%S)-%>-(%P)---"
set status_on_top=yes

I do not set the variable attach_format.

  • Operating System and its version

Ubuntu 22.04 LTS

  • Is your email local (maildir) or remote (IMAP)?

IMAP.

@Knusper Knusper added the type:bug Bug label Apr 25, 2024
@flatcap
Copy link
Member

flatcap commented Apr 25, 2024

Thanks for the detailed bug report.

Unfortunately, I can't repeat the problem and the code looks sane.
I tried both Release 2024-03-29 and the current dev code.

Please can you try with minimal config, your test.rc from above:

neomutt -n -F test.rc

Notes to self:

  • op_attachment_attach_file(): Attach File succeeds, triggering notification: (NT_EMAIL, NT_EMAIL_CHANGE_ATTACH)
    • cbar_email_observer(): Compose bar receives notification: sets flag WA_RECALC
  • Returns back to dlg_compose() (the Compose Dialog), where it calls window_redraw() to refresh everything
    • cbar_recalc(): Compose bar recalculates, sets flag WA_REPAINT
    • cbar_repaint(): Compose bar repaints

@Knusper
Copy link
Author

Knusper commented Apr 25, 2024

Can reproduce with my "minimal config" that only affects display.
I started with neomutt -n -F ~/.mutt/display and I repat the display file from my config below:

# status bar
set status_format="-%r- %f [Msgs:%?M?%M/?%m%?n? New:%n?%?o? Old:%o?%?d? Del:%d?%?F? Flag:%F?%?t? Tag:%t?%?p? Post:%p?%?b? Size: %l?]---(%s/%S)-%>-(%P)---"
set status_on_top=yes
# index_format
set index_format="%4C %Z %{%b %d} %-23.23L (%?l?%4l&%4c?) %s"

# attach format
# set attach_format"%u%D%I %t%4n %T%.40d%> [%.7m/%.10M, %.6e%?C?, %C?, %s] "

# What headers to show
ignore *
unignore from: date subject to cc reply-to:
unignore resent- x-resent

# What order to show them
unhdr_order *
hdr_order Date: From: To: Reply-To: Cc: Subject:

set sort = reverse-date-received

# Pager
set pager_context=4  
set pager_index_lines=10
set pager_stop
unset markers


## ZENBURN COLOR SCHEME FOR MUTT 
# general-doesn't-fit stuff
color normal     color188 color237
color error      color115 color236
color markers    color142 color238
color tilde      color108 color237
color status     color144 color234

# index stuff
color indicator  color108 color236
color tree       color109 color237
color index      color188 color237 ~A
color index      color188 color237 ~N
color index      color188 color237 ~O
color index      color174 color237 ~F
color index      color174 color237 ~D

# header stuff
color hdrdefault color223 color237
color header     color223 color237 "^Subject"

# gpg stuff
color body       color188 color237 "^gpg: Good signature.*"
color body       color115 color236 "^gpg: BAD signature.*"
color body       color174 color237 "^gpg: Can't check signature.*"
color body       color174 color237 "^-----BEGIN PGP SIGNED MESSAGE-----"
color body       color174 color237 "^-----BEGIN PGP SIGNATURE-----"
color body       color174 color237 "^-----END PGP SIGNED MESSAGE-----"
color body       color174 color237 "^-----END PGP SIGNATURE-----"
color body       color174 color237 "^Version: GnuPG.*"
color body       color174 color237 "^Comment: .*"

# url, email and web stuff
color body       color174 color237 "(finger|ftp|http|https|news|telnet)://[^ >]*"
color body       color174 color237 "<URL:[^ ]*>"
color body       color174 color237 "www\\.[-.a-z0-9]+\\.[a-z][a-z][a-z]?([-_./~a-z0-9]+)?"
color body       color174 color237 "mailto: *[^ ]+\(\\i?subject=[^ ]+\)?"
color body       color174 color237 "[-a-z_0-9.%$]+@[-a-z_0-9.]+\\.[-a-z][-a-z]+"

# misc body stuff
color attachment color174 color237 #Add-ons to the message
color signature  color223 color237

# quote levels
color quoted     color108 color237
color quoted1    color116 color237
color quoted2    color247 color237
color quoted3    color108 color237
color quoted4    color116 color237
color quoted5    color247 color237
color quoted6    color108 color237
color quoted7    color116 color237
color quoted8    color247 color237
color quoted9    color108 color237

@Knusper
Copy link
Author

Knusper commented Apr 25, 2024

It persists even with an empty configuration file ... then the status from the file browser is shown at the bottom of the compose menu in the compose menu. When I resize the window the status bar updates correctly....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants