expando: padding default to space #4277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brilliant, thanks! Now that I know what the problem was, I'll rework this PR (soon-ish) to display an error message. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| case 'y': | ||
| tm.tm_year -= priv->count; | ||
| tm.tm_year -= count; |
Check warning
Code scanning / CodeQL
Year field changed using an arithmetic operation without checking for leap year Warning
flatcap
force-pushed
the
devel/padding
branch
3 times, most recently
from
ba081eb
to
109ade5
Compare
If we can't parse the padding character, default to space for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we can't parse the padding character, default to space for now.
This may fix #4270
If a format string ended in
%>(hard padding), but it omitted the padding character,then NeoMutt would get stuck in a loop trying to pad out a string with
""(nothing).