mail check and notifications #4053
roccoblues
started this conversation in
Development
Replies: 4 comments
-
Yeah, I think this layered approach is the way forward. |
Beta Was this translation helpful? Give feedback.
0 replies
-
+1 |
Beta Was this translation helpful? Give feedback.
0 replies
-
From an IRC discussion: When do we need to check all mailboxes?
When do we need to check a specific mailbox?
The current mail checks after running external commands ( |
Beta Was this translation helpful? Give feedback.
0 replies
-
Playing around with a new-mail observer: #4077 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Issues:
Recent refactoring broke the mail check for the current mailbox after running an external command (new mail display + notification missing after external command #4048 (comment)).
dlg_index() and dlg_pager()) duplicate the code to check for new mail and trigger the corresponding actions.
mutt_mailbox_check() claims to check all mailboxes for new mail but it skips the current one. I guess that is because the current mailbox is checked in the event loops but it's still confusing.
Naive refactoring idea:
Remove the mail check from the event loops and add a
$timeout
handler that according to$mail_check
and$mail_check_stats_interval
triggers the checks. That also sends out aNT_MAILBOX
notification if we have new mail.That can be picked up by a handler that runs all the actions: beep, show the "new mail" message and run
new_mail_command
.Beta Was this translation helpful? Give feedback.
All reactions