Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There may be problems with color matching #38

Open
fbigun opened this issue Jun 22, 2018 · 2 comments
Open

There may be problems with color matching #38

fbigun opened this issue Jun 22, 2018 · 2 comments

Comments

@fbigun
Copy link

fbigun commented Jun 22, 2018

After using the light theme, enter the following command and the numeric part will not be echoed.

eg1

curl 12132132 fsd.exe
@woodscn
Copy link

woodscn commented Mar 25, 2021

The light theme is almost unreadable. I think the color mapping in incorrect; it shouldn't be as simple as swapping the background color.

@rbeesley
Copy link
Collaborator

There are several things moving right now which complicate things. PowerShell has been changing the way it references terminal colors and the console team has been changing things as well. When I started contributing to this project it was easy, PS 5 at most and conhost. Then with PSReadLine 2.0 there were some breaking changes, and PowerShell 7.2 is bringing more changes.

On Windows 10, the best way make this work today is to use Windows Terminal. The team even has Solarized built in. I think problems mapping the colors comes from one of the aforementioned changes.

@fbigun, if I don't understand the issue, please attach a screenshot (you can paste them directly into github) and please provide some context with respect to the OS, shell, terminal, and respective versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants