Question. what is mean "Remove setNativeProps API" ?

[sacru2red]

I saw commit [change] Remove setNativeProps API

I can't understand this. but I have Issue under

I update rnw 18.12 => 19.6, now

some packages got errors

indicatorRef.current.setNativeProps({....})

I wonder It's related or not

Thanks

Steps to reproduce

react-native-web ^0.19.6
react ^18.2.0
react-native-paper-tabs": "^0.7.0",

[sacru2red]

@necolas
I found you comment

It seems like having message "setNativeProps is deprecated. Please update props using React state instead." on 2023-02-07

I don't think have this issue on now.

1. #migrating-off-setnativeprops part is gone. atfer 0.72 doc
2. RN change-logs has no mention this issue

[sacru2red]

so, should we revert commit ?

[sacru2red]

I think better way not remove setNativeProps.
some libs or codes use setNativeProps. If keep delete, this is bring high cost to fix 3rd party lib's code.
I think "Add setNativeProps to Fabric" commit is similar with my idea

[vipulrawat]

I agree that to provide a better backward compatibility setNativeProps should be brought back as many libraries still use the API. As mentioned in the comment above, RN is also bringing it back for the same reason.

[niklasmachacek]

We have been using setNativeProps to update the text of a TextInput inside an animation.

Without setNativeProps it is simply not possible to have smooth animations here by updating the React State, as mentioned in this ticket.

Please consider reverting the commit and getting setNativeProps back in!

[sacru2red]

@necolas ping. how about your opinion?

[nabilfreeman]

At first look of this thread today I thought this was a terrible change that needed to be reverted.

But, after some further thought and research it looks like setNativeProps is still going to be phased out of React Native.

I think this should eventually be removed, but I'm not sure if removing it ahead of the core team is a good idea. react-native-web is a hugely important part of the RN ecosystem and I would expect any changes to be timed with those in RN core for maximum compatibility.

Maybe more of a philosophical & DX question.

Personally I'm going to push through this issue with some patching on the culprit 3rd party library causing this problem, which is quite old anyway.

[jonathanj]

facebook/react-native#34391 (comment)

[niklasmachacek]

I went ahead and filed a new issue here suggesting that the setNativeProps API should be implemented again, since it is now supported in Fabric after react-native 0.72 as seen here.

[nabilfreeman]

Yes, if it has been added back to Fabric, then it makes sense to restore it here as well IMO