Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine pre and code, kbd, sample declarations #772

Open
erdaltsksn opened this issue Jan 2, 2019 · 3 comments · May be fixed by #773
Open

Combine pre and code, kbd, sample declarations #772

erdaltsksn opened this issue Jan 2, 2019 · 3 comments · May be fixed by #773

Comments

@erdaltsksn
Copy link

There are two separate declaration with same properties. Is it possible to combine them?

CURRENT:

/**
 * 1. Correct the inheritance and scaling of font size in all browsers.
 * 2. Correct the odd `em` font sizing in all browsers.
 */

pre {
  font-family: monospace, monospace; /* 1 */
  font-size: 1em; /* 2 */
}

/**
 * 1. Correct the inheritance and scaling of font size in all browsers.
 * 2. Correct the odd `em` font sizing in all browsers.
 */

code,
kbd,
samp {
  font-family: monospace, monospace; /* 1 */
  font-size: 1em; /* 2 */
}

PROPOSED:

/**
 * 1. Correct the inheritance and scaling of font size in all browsers.
 * 2. Correct the odd `em` font sizing in all browsers.
 */

pre,
code,
kbd,
samp {
  font-family: monospace, monospace; /* 1 */
  font-size: 1em; /* 2 */
}
@erdaltsksn erdaltsksn linked a pull request Jan 3, 2019 that will close this issue
Open
@ReenaSingh07
Copy link

can i work with this?

@erdaltsksn
Copy link
Author

can i work with this?

I have already sent a pull request for this.

@seothemes
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combine pre and code,kbd,sample declarations
3 participants
@erdaltsksn @seothemes @ReenaSingh07