Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS minimal permission policy: added it to version control. #1616

Merged

Conversation

rdegraaf
Copy link

@rdegraaf rdegraaf commented Mar 5, 2024

Description

This change adds a copy of the AWS minimal permission policy from https://github.com/nccgroup/ScoutSuite/wiki/AWS-Minimal-Privileges-Policy into version control. It also has the permissions required for merge request #1614.

It does not fully address #1615. Additional changes that cannot be made directly through this MR will be necessary, along the lines of the following:

  • Once the next release is made, remove https://github.com/nccgroup/ScoutSuite/wiki/AWS-Minimal-Privileges-Policy and replace it with a link to https://github.com/nccgroup/ScoutSuite/tree/5.14.0/doc/aws-minimal-permission-policy, substituting the correct release tag.
  • The process for making a release should be amended to include updating the minimal permission policy link in the wiki, or something equivalent such as creating a "latest" tag that is updated with every release and using a link through that tag in the wiki.
  • A checkbox confirming that the developer has added any required permissions to the minimal permission policies should be added to the merge request template.
  • Someone will need to review all MRs accepted since the 5.13 release but before this one and add any additional required permissions to the minimal permission policy.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@rdegraaf rdegraaf changed the base branch from master to develop March 5, 2024 19:19
@fernando-gallego fernando-gallego self-assigned this May 9, 2024
@fernando-gallego fernando-gallego merged commit 1759a87 into nccgroup:develop May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Move minimal permission policies to source repo
3 participants