Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import filters when referencing other filters #205

Open
ldionmarcil opened this issue Jan 25, 2024 · 0 comments
Open

Cannot import filters when referencing other filters #205

ldionmarcil opened this issue Jan 25, 2024 · 0 comments
Assignees
Labels

Comments

@ldionmarcil
Copy link
Contributor

Description:

Steps To Reproduce:
Try to import multiple filters, where some of the filters that have references to other imported filters. None of the filters are imported. No error messages are generated.

Example filters to import:

[
    {
        "uid": "c56c5be1-2032-4301-b8b4-944f67137629",
        "name": "ok",
        "filter": {
            "filter": "Response.Status == 200"
        }
    },
    {
        "uid": "2ec0a650-b824-4cf9-b385-99e688d0c268",
        "name": "json",
        "filter": {
            "filter": "Response.Type == \"json\" AND #ok"
        }
    }
]

I think because filter #json requires filter #ok, and both get imported/parsed at the same time, the filter import logic detects filter #ok as being missing (not fully imported). As a result, nothing ends up happening. This is especially broken for me because it means I cannot export/import my filters, as none of them get imported if one of them is seen as "broken".

Expected behavior:
All filters are imported.

Version:
v3.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants