Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Smart playlists do not refetch tracks from child smart playlists used in rules #3017

Open
3 tasks done
reillymc opened this issue May 12, 2024 · 0 comments · May be fixed by #3018
Open
3 tasks done

[Bug]: Smart playlists do not refetch tracks from child smart playlists used in rules #3017

reillymc opened this issue May 12, 2024 · 0 comments · May be fixed by #3018
Labels
bug triage New bug reports that need to be evaluated

Comments

@reillymc
Copy link

I confirm that:

  • I have searched the existing open AND closed issues to see if an issue already exists for the bug I've encountered
  • I'm using the latest version (your issue may have been fixed already)

Version

0.52.0 (92a98cd)

Current Behavior

When fetching a smart playlist that uses the inPlaylistor notInPlaylist rules, the child smart playlists from these rules are not refreshed first. This means if the child playlists use a random selection of songs with a limit, the main smart playlist will always refresh with the same selection of songs, unless the child playlists are manually refreshed beforehand.

Expected Behavior

When fetching a smart playlists, all smart playlist dependencies from the defined rules should also be refreshed to ensure a new set of random songs is selected.

Steps To Reproduce

  1. In this scenario, the music folder has a 6 tracks, 2 of which have a comment with the text "A" and the other 2 with the text "B". The following smart playlists are also present.

SmartPlaylistA (4b186cad-1368-41c7-83c1-f5198da684d3)

{
    "any": [
        {
            "contains": {
                "comment": "A"
            }
        }
    ],
    "sort": "random",
    "limit": 2
}

SmartPlaylistB (c7f71bd2-35d4-4055-bc3b-555a884b1384)

{
    "any": [
        {
            "contains": {
                "comment": "B"
            }
        }
    ],
    "sort": "random",
    "limit": 2
}

MainSmartPlaylist

{
    "any": [
        {
            "inPlaylist": {
                "id": "4b186cad-1368-41c7-83c1-f5198da684d3"
            }
        },
        {
            "inPlaylist": {
                "id": "c7f71bd2-35d4-4055-bc3b-555a884b1384"
            }
        }
    ],
    "sort": "random"
}
  1. When accessing MainSmartPlaylist via the Navidrome UI or a client using the API, refreshing will not change the song selections. The same two A songs and B songs are always present, so the remaining two songs are never in the playlist unless SmartPlaylistA/SmartPlaylistB are manually refreshed.

Environment

- OS: Ubuntu 22.04
- Browser: Firefox 125.02
- Client: Amperfy (on iOS)

How Navidrome is installed?

Docker

Configuration

No response

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow Navidrome's Code of Conduct
@reillymc reillymc added bug triage New bug reports that need to be evaluated labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage New bug reports that need to be evaluated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant