New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaults method like request.defaults #163
Comments
@jmeas Apart from opinions which are always welcome, would you mind sharing if this form of extending xhr fulfills your needs (the ones originally leading to your PR with qs) ? |
I think it would fulfill my needs, @naugtur . If we added this, we could revert the other API, with the added benefit of being more consistent with |
My point exactly. BTW. I'm looking for someone to share npm publishing access too. |
@naugtur , I've got it on my to do list to dig more into this library. I'm going to work on those integration tests first, I think. Time permitting, I'd be happy to help out with more, too. |
I may have time this week to implement but I can't make that promise. If you get to it first, @naugtur, I'd be happy to review. |
The
defaults
method in the request library is useful for creating a new request function with some options already set. It can also take arequester
function, which is a lightweight way to extend functionality. Therequester
is undocumented but is at this point not much code to implement and could be an interesting refactor for xhr.The text was updated successfully, but these errors were encountered: