Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error check? #91

Open
MJohnson20 opened this issue Jan 12, 2023 · 0 comments · May be fixed by #92
Open

Incorrect error check? #91

MJohnson20 opened this issue Jan 12, 2023 · 0 comments · May be fixed by #92

Comments

@MJohnson20
Copy link

MJohnson20 commented Jan 12, 2023

if(not os.path.isdir(driverPath)):

If specifying a path to a web driver in the selenium webdriver constructor it looks like it expects a full path, including the filename. However, this error checking of the passed driverPath into the webbot constructor (which is then passed to the webdriver constructor) checks to see if it's not a directory. This should probably check if it's not a file instead.

@jerry153fish jerry153fish linked a pull request Feb 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant