-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.config instead of config #34
Comments
Hi @natemoo-re! We also started a new effort for |
aljazerzen
added a commit
to aljazerzen/lintrunner
that referenced
this issue
Mar 25, 2024
Adds `.config/lintrunner.toml` and `.config/lintrunner.private.toml` to the end of default config paths. Idea here is that having too much dot files in the repo root is a mess. Alternative is a `.config/`, which alieviates the problem a lot. See https://dot-config.github.io/ and natemoo-re/proload#34. This is potentially a breaking change, since project that currenty default to `.lintrunner.toml` but also has `.config/lintrunner.toml` will now have root config overridden with the `.config`. The chance of this happening are very low, so I don't think this will cause any problems. --- Alternative is to put the new default in the front of the list, but then we would have to change the full default to: ``` .config/lintrunner.toml, .config/lintrunner.private.toml, ../.lintrunner.toml, ../.lintrunner.private.toml ``` ... since this the last two paths must be relative to `.config`, which is confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I've noticed movement in the ecosystem recently to consolidate around a convention to have configs inside of a directory.
See:
But this consolidation is specifically around a directory named ".config".
From the README,
proload
seems to only supportconfig
.Should that be reconsidered?
The text was updated successfully, but these errors were encountered: