-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments in local SVG files are removed regardless of configuration #177
Labels
enhancement
New feature or request
Comments
I dug into this a little bit, and it looks like we are passing the astro-icon/packages/core/src/loaders/loadLocalCollection.ts Lines 16 to 19 in 38a3a90
It's possible that refactoring this logic to use our own loading mechanism would solve this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of
astro-icon
are you using?v1.0.1
Astro Info
If this issue only occurs in one browser, which browser is a problem?
No response
Describe the Bug
When using a local SVG file (containing comments
<!-- -->
) from theicons
folder, the rendered HTML does not contain the comments, although the SVGO pluginremoveComments
is disabled in the config file:What's the expected result?
Comments should be preserved in the final output, since some icons (e.g. Font Awesome) require the CC BY 4.0 license notice (https://fontawesome.com/license/free)
Link to Minimal Reproducible Example
https://stackblitz.com/edit/github-aqxtyy?file=astro.config.mjs
The text was updated successfully, but these errors were encountered: