Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on linux/amd64 #126

Open
raws0cket opened this issue Aug 30, 2020 · 5 comments
Open

Building on linux/amd64 #126

raws0cket opened this issue Aug 30, 2020 · 5 comments

Comments

@raws0cket
Copy link

raws0cket commented Aug 30, 2020

I'm trying to build via "option A" (https://github.com/namecoin/ncdns)
At the last step (go get -t github.com/namecoin/ncdns/...) i have this error:

# github.com/namecoin/x509-signature-splice/x509
go/work/src/github.com/namecoin/x509-signature-splice/x509/x509_splice.go:142:36: not enough arguments in call to buildExtensions
        have (*Certificate, bool, []byte)
        want (*Certificate, bool, []byte, []byte)

Version of Go is 1.15

@JeremyRand
Copy link
Member

Thanks for the bug report. Looks like you've hit this bug: namecoin/x509-signature-splice#14

Is downgrading Go an option for you? Go 1.13.x definitely should work; Go 1.14.x might work too (not sure). The x509-signature-splice codebase is to-be-deprecated, since we've found better ways (e.g. namecoin/x509-signature-splice#12 ) to achieve those goals, so I'm not particularly motivated to keep rebasing it periodically unless we have users who urgently need it to be rebased before those alternate methods are ready for release.

@raws0cket
Copy link
Author

I have downgraded version of Go to 1.14.7 and it works.

@c00w
Copy link

c00w commented Dec 30, 2020

FYI - go 1.13 is actually unsupported, and go1.14 will be unsupported when go 1.16 releases in febuary - any way you can just tag a new version since it looks like the fix is already merged?

c00w added a commit to c00w/nixpkgs that referenced this issue Dec 30, 2020
I've poked them to tag a new version at
namecoin/ncdns#126, but master builds cleanly
with go1.15, so I just updated to unstable
@JeremyRand
Copy link
Member

FYI - go 1.13 is actually unsupported, and go1.14 will be unsupported when go 1.16 releases in febuary - any way you can just tag a new version since it looks like the fix is already merged?

Thanks for the poke @c00w. Yes, the fix is merged to ncdns master, and I'd expect it to work fine. That said, I don't think we've done a huge amount of QA testing of master -- but on the other hand I'd be surprised if anything is significantly broken. I'm tentatively planning to tag a new release in January, but if NixOS needs a new tag quickly, let me know and I can try to expedite things. Cheers!

@c00w
Copy link

c00w commented Dec 30, 2020

shrug January is likely fine :) - I'm just upgrading nixos to run of an unstable version of ncdns so we're unblocked. I also can't promise it will get merged quickly. I will note that if you tagged regular releases, nixos version upgrade infrastructure may have been able to automatically upgrade this package without a human being involved.

As a side note, any idea why it looks like all the namecoin repos aren't using go modules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants