Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag nc22.0 #491

Open
JeremyRand opened this issue Feb 4, 2022 · 3 comments
Open

Tag nc22.0 #491

JeremyRand opened this issue Feb 4, 2022 · 3 comments

Comments

@JeremyRand
Copy link
Member

I've just pushed a 22.0-draft branch. This branch is identical to nc0.22.0 except 3 backported bugfixes from the 22.x branch have been cherry-picked. @domob1812 Can you take a look at the 22.0-draft branch and check that it looks okay? If it passes your review, can you rename that branch to 22.0 (i.e. remove the -draft suffix) and tag it as nc22.0 (no leading 0. in the version number)?
@domob1812
Copy link

Out of curiosity, what are the backports and why can't we use the 22.x branch as basis?

@JeremyRand
Copy link
Member Author

They're the same bugfixes that we already backported to 22.x from master. I'm hesitant to tag from 22.x directly since that contains upstream Bitcoin commits that aren't part of a Bitcoin tag, which means they've gotten less QA testing and makes it harder for Namecoin users to reason about what Bitcoin commits they're getting from our tag.

@domob1812
Copy link

Makes sense, all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeremyRand @domob1812