-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: why case .isLoading
is not called even we got .isLoading
on didSet?
#76
Comments
As I looked definition of
Is this the reason why? p.s. If I set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, thanks for sharing and committing such a great project.
While using your architecture, I found that the the scope below is not always called:
clean-architecture-swiftui/CountriesSwiftUI/UI/Screens/CountryDetails/CountryDetails.swift
Lines 28 to 29 in 9f2a98a
even though you did
setIsLoading
at below:clean-architecture-swiftui/CountriesSwiftUI/Services/CountriesService.swift
Line 68 in 9f2a98a
Is this behavior intended?
What I'm expecting is that the loading view will be shown if you enter the view every time. But, it's not.
I've also checked actual value with
then I got
so I expected CountryDetails.swift#L29 to be run, but it's not.
It may be very basic behavior or just an overlook of me but I appreciate anyone's help.
The text was updated successfully, but these errors were encountered: