Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shm_size_mb argument of pandarallel.initialize is never used #222

Open
2 tasks
overmode opened this issue Feb 3, 2023 · 3 comments · May be fixed by #269
Open
2 tasks

shm_size_mb argument of pandarallel.initialize is never used #222

overmode opened this issue Feb 3, 2023 · 3 comments · May be fixed by #269

Comments

@overmode
Copy link

overmode commented Feb 3, 2023

General

  • Operating System: ~
  • Python version: ~
  • Pandas version: ~
  • Pandarallel version: v1.6.4

Acknowledgement

  • My issue is NOT present when using pandas without alone (without pandarallel)
  • If I am on Windows, I read the Troubleshooting page
    before writing a new bug report

Bug description

It seems like the shm_size_mb argument of the initialize is never used

Observed behavior

Do a search in https://github.com/nalepae/pandarallel/blob/master/pandarallel/core.py

Expected behavior

The term should be used somewhere else than in the signature

Minimal but working code sample to ease bug fix for pandarallel team

~
@till-m
Copy link
Collaborator

till-m commented Feb 3, 2023

The argument has indeed been deprecated, as can be seen here. I guess there is an argument to be made for raising a DeprecationWarning and removing it a few releases from now. I'll try to get around to implementing this change, but I'm a bit busy right now.

@overmode
Copy link
Author

overmode commented Feb 3, 2023 •
edited

Nice, thank you !
If I find time, I can push a very basic PR

@nalepae
Copy link
Owner

nalepae commented Jan 23, 2024

Pandaral·lel is looking for a maintainer!
If you are interested, please open an GitHub issue.

@shermansiu shermansiu linked a pull request Apr 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Pandarallel initialization. shermansiu/pandarallel
3 participants
@nalepae @overmode @till-m