CHANGELOG.md

Changelog

7.0.0-beta.4 (2020-05-09)

Full Changelog

Implemented enhancements:

• Move currency selection to admin settings #671
• Center live map to custom location #661
• Pilot Names - Pilots ID #656
• Simbrief sample data #651
• Simbrief only available for bids #642
• PIREP prefile download #634
• Importer - group imported aircraft by type #628
• API: When looking up flight, return the load factor #611
• API: On prefile, return required fields #610
• Center on active flights #605
• Profiling/performance improvments #602
• Aircraft stats resync #585
• Cron Job #553
• Importing a CSV with additional airports clears all previous airports #490
• Use continuation token instead of page/offset #469
• Combine the Util classes in Facade and Support #467
• ACARS/Live flight events #436
• Allow logo upload for airline #417
• Google Analytics Settings #382
• Let update only be run if logged in/admin #372
• Airport Lookup - possible additions #364
• Set flight type for expenses for flight #348
• Extend search schedule options #297
• Change currency from settings #671 #672
• Add privatized version of name #656 #658
• Add Simbrief entries as sample data for load #651 #652
• Option for SB only on bids; add the new file type #642 #643
• Account ICAO for subfleet, airline/location if columns exist #628 #632
• Performance improvements #602 #607
• Center on active flights #605 #606
• Installer fixes, remove bcmath, fix design #596
• Remove airport length restrictions #590 #592
• Remove 4 char restriction from ICAO; use decimal type for lat/lon #590 #591
• Recalcuate aircraft stats in nightly cron and importer #585 #443 #587
• (Importer) Set the pay rate for the ranks #443 #586
• Fix rowmapper generator, check for fields, map users #443 #583
• Add bcmath to the required extensions list #558 #564
• Add the argc_argv flag for the cgi exec #553 #556
• Add logo to the flights page if its set #417 #550
• Add additional events for PIREP states #436 #548
• Cleanup Utils #467 #547
• Add checkbox to clear previous data when importing #490 #546
• Distro zip file from tar file #449 #543
• Spanish files translation #542
• Add link to download ACARS config from profile #539
• Format all blade templates to 2 spaces #530 #531
• Add menu bar for mobile #529
• Fix live and route map errors #527 #528
• Set PIREPs page to public #526
• Try to clear caches before updating #522
• Reduce number of queries for update check #520
• Add getRootDomain() to Utils #514
• Search flights by subfleet #484 #506
• Add base Dockerfile for Dockerhub upload #504
• Add reference to docs on doc site #502
• Add new command to export a specific PIREP for debugging #501
• Flight search for departure/arrival airports not using column names #496
• Split the importer module out from the installer module #468

Fixed bugs:

• Aircraft hours not counting #683
• Error creating first user/airline #677
• submitting PIREP: Page Not Found #676
• Filing manual report causes SimBrief Error #668
• Error on finance page in admin #667
• API: User bids aren't loading SimBrief data for flight #664
• .: Links to pilot profiles :. #655
• Some domains (ex, .co.uk) not properly parsed #647
• API: Load bids through the bids.flight fields, not the flights field on the user #639
• Login page not using theme #638
• CSV import error says "csv not found" #636
• Importer - schedules not importing properly #630
• Disable using of php opcache #625
• API: Flight fields are an array when empty #618
• "Pending Pireps" in admin is blank #616
• Flight fields show all fields, not custom added ones #614
• Mixed content causes error #612
• Fares not appearing in API response for user/subfleets #608
• Not selecting active for aircraft shows nullable error #603
• Airports page repeats airport name (infinite loop) #599
• Calculate Distance button not working #595
• Support Seaports with 3 letter IATA/ID codes #590
• Hubs only show for registration #580
• Error when updating user in admin #576
• Updater not working because Source repository [github] is not defined #575
• Flights Page Search Subfleet Column #574
• Duplicate key entry for ACARS data #572
• No hint path defined for updater #570
• My Bids Page Error #561
• I can't change Current Theme #554
• Pilots cannot use the dashboard or flights without admin rights #480
• Database prefix not being applied #442
• Install not working #411
• typo in dependency on 'leaflet.geodesic' #687
• Emails/notifications not sending #675 #686
• Aircraft hours not showing/incrementing #683 #684
• METAR: KM as unit in visibility #680 #682
• Blank/null IATA code isn't unique when added #679 #681
• Fix airline creation in installer #677 #678
• Journal not created when airline is created #667 #670
• Check for SB being avail before filing #668 #669
• Load Simbrief and flight data when getting bids #664 #665
• Fix pilots page not showing up #655 #660
• Fix PirepComment response; 201 to 200 #654
• Domain detection failing for .co.uk, etc #647 #648
• Auth routes not using themes #638 #645
• Don't return bids by default, fix user flight column #639 #640
• Account for admin role, don't error out on null rows #632 #637
• Fix airline mapping for aircraft #628 #633
• Increase ID column size; seed ID generator with uniqid() #630 #631
• Disable using apc/opcache by default if found #625 #629
• Fix saving of fare #621 #624
• API: Flight fields are an array when empty #618 #619
• Remove the flight fields link from admin #614 #615
• HTTP/HTTPS mixed content errors #612 #613
• Fare information not included in subfleet response #608 #609
• Aircraft status field blank causes error #603 #604
• METAR parsing infinite loop bugfix #599 #600
• Table prefixes not being added to indexes #597
• Import expense and ledger entries #443 #588
• User country mapping; ignore unused groups #443 #584
• Change fuel used to optional #512 #582
• Respect home hubs setting for registration #580 #581
• Upstream null version; build version tags not being saved properly #575 #578
• Fix edit pilot error (Facade\Utils missing) #576 #577
• Upsert on ACARS positions #572 #573
• Fix the namespace path on updater templates #570 #571
• Route not found error for Pirep::resource() call #559 #565
• Add extra check for $acars being set #560 #563
• Missing $subfleet error on bids page #561 #562
• Refresh theme cache on settings page load #554 #557
• Fix migrations when table prefix is involved #442 #555
• Use optional() around the airport fields #537
• PIREPS resource except for show #536
• Fix import during flight cron #532 #535
• Fix PIREP edit endpoint #534
• Add a public_url() helper #513 #519
• Correct text for no subfleets #507 #518
• Error page not showing when database isn't configured #517
• Check user permissions on the routes #508 #516
• Show admin dropdown for admin-access ability #515
• New subfleet not being attached to an airline on import #479 #505
• Importing not updating existing items #486 #503
• Set a default model value for airports on PIREP #500
• Fix GeoService errors when viewing PIREP #498 #499
• Properly set the distance/planned_distance #497
• 491 Installation Error #495
• Return the flight fares if there are no subfleet fares #488 #489
• Error if there are no roles when editing a user #480 #483
• Allow nullable field and calculate distance if nulled #482
• Pilots cannot use the dashboard or flights without admin rights #481
• Fix BindingResolutionError when debug toolbar isn't present #465
• Fix CSV imports giving Storage class not found #454 #462
• Use PhpExecutableFinder() closes #457 #458 #460
• Avoid proc_open use #455 #456
• Stricter checks on ACARS API data #451
• Remove bootstrap cache #448

Closed issues:

• Dashboard error when METAR visibility in KM #680
• Error adding multiple airlines without IATA codes #679
• Pages #641
• Create a "fare type" for cargo #621
• Split Sample module out into separate repo #593
• No way to add files to fleet #567
• Map Center Coords #566
• Pilot Profile Page Error #560
• File New Pirep #559
• I can't add new flight #558
• Pilot Pay route modifier #487
• Auto-update #449
• Setting to not automatically calculate distances #446
• Classic importer #443
• SimBrief integration - pirep prefile #405
• PIREP rejection doesn't move pilot back to previous airport #392
• Load Factor for flights #352

Merged pull requests:

• Upgrade packages with security alerts #653
• Add public/private pages #641 #644
• SimBrief integration #405 #635
• Add fare type for pax/cargo/mixed flights #621 #623
• Add fixed pilot pay for a flight #487 #622
• Add load factor and variance to flights #352 #620
• Module/plugin installation working #593 #594
• Add Google Analytics tracking ID to settings and to main template #382 #551
• Set expenses on specific flight types #348 #549
• Auto update #449 #545
• Auto-update functionality #449 #544
• ACARS XML config file download #540
• Make the fuel used optional #512
• Add PHP 7.4 support #464
• Replace importer with AJAX powered; better error handling #443 #447
• Fix missing newsRepo variable #445
• Refactor and add importer to Installer module #443 #444
• 391 Notification refactorings #441

7.0.0-beta.3 (2020-02-08)

Full Changelog

Implemented enhancements:

• Fix formatting in blade files #530
• Make PIREP view page public #525
• Fix map line colors #523
• Null-able fuel values on PIREP #510
• include subfleet in search options #484
• PHP 7.4 in Travis #463
• Move cron problem report to main page #458

Fixed bugs:

• Method GET for /pireps/<id>/edit not supported #533
• Cron error for removing expired flights #532
• Live map marker click not working #527
• Redirect to installer properly #513
• Admin panel link not shown for users in role group #509
• Users without "admin" role can modify roles #508
• Edit flights page - text error #507
• Installation error with external databases #494
• Pirep not in KG #493
• Installation Error step2 #491
• Fares assigned to flights not working/overwritten by Subfleet #488
• Status not changing when importing CSV for aircraft #486
• Default Theme unusable on Mobile #485
• Fatal Error in subfleet page when importing routes with new aircraft #479
• Flights CSV import fails if no distance stipulated #478
• Subfleet CSV import #476
• Cron - DateTime::construct() expects parameter 2 to be DateTimeZone, int given #461
• if PHP_CLI not found in cron maintenance, put generic php exec there #457
• Importing schedule bug #454
• The updater/installer should clear all caches #408

Closed issues:

• Error 500 when trying to access Dashboard. #498
• Import multiple aircraft of different subtypes in one sheet #477
• Split out installer/importer from updater #453
• ACARS update fields can be nulled #450
• Retryable HTTP client #430
• Pireps page: 'Pending' doesn't show pending PIREPs #427
• Email when news sent out #391
• Save cron last run time #386

Merged pull requests:

• 7.0.0-beta3 Release #541

7.0.0-beta.2 (2019-11-19)

Full Changelog

Implemented enhancements:

• CSS Love needed for the Flights Page #418
• Add Subfleet, Custom Fields and Fares during initial schedule entry #410
• PIREP from flight/bid; orig: Bid not removed after flight accepted #406
• Auto airport lookup #404
• API Changes #389
• "Maintenance" section in admin #376
• Auto-calculate Distance on Add Flight page #355
• Change PIREP fuel field type #340
• Fuel in pireps #295
• Add field to set aircraft location #277
• Suggestion: edit pilot ID #265
• Combine subfleet and aircraft export #233
• Allow URL for downloads #229
• Move settings into database seeder #224
• Allow specifying transfer hours on registration #129
• Backend changes separating id from pilot_id #324

Fixed bugs:

• Flight ID's and Airport ICAO's not clickable on airport page #419
• Distance lookup needs bcmath extension #407
• Missing flight level field on frontend #401
• Set distance to 0 if no value #400
• Upload livery via admin #398
• Block deleting airline if there are assets associated with it #367
• Cron not calculating number of flights #357
• Error Seeing data of pilot profile #351
• Fresh install doesn't create rank #346
• Fuel cost only allows whole numbers for price #342
• API calls in subfolder going to root domain #339
• Errors versión 7.0.0 (compilación 181025-6f7735) #332
• Error on Install #303
• Having a "Error 505" when trying to install PHPVMS #302
• Error when viewing profile or trying to add flights #291
• "Hubs as home airport" doesn't work #288
• Undocumented Extension Required - PHP 7.2 GMP #285
• ErrorException Trying to get property 'name' of non-object #281

Closed issues:

• Add settings.yaml changes to update available check #437
• Write current version to DB #428
• Message for configuring cron #424
• Opt in for telemetry on install #415
• Error when saving a PIREP without filling some fields and attempting to edit it #414
• Update htaccess file #412
• Allow typing in drop down menus #409
• Malformed email error on file #402
• Residual design issues from Bootstrap update #397
• Don't allow PIREP cancel if not in PENDING phase #395
• Pageable Criteria #390
• Update CSS Libraries #387
• Laravel 6 #384
• Profile menu dropdown #383
• Update vaCentral Library #380
• Implement Laravel 5.7 Notifications #378
• Generate random cache prefix on install #374
• Move transaction/journal code out of controller #370
• Add Contract for Airport information lookup #363
• RFC7807 - Standardize API error messages #361
• Imposible delete bid #360
• Change theme from settings #359
• Integration with PACX [Feature] #338
• Why don't you create a free ACARS for PHPVMS7 testing? #336
• Error add Roles #334
• Error during installation #333
• spatie - laravel-backup #330
• Refactor data seeding #329
• Notify/download latest version file as part of cron #327
• Notify if migration/updates are pending #326
• PIREP ID change #318
• Missing folders on install #316
• Pull in VMACars plugin #315
• Account for fuel in the finances #313
• Show module in the external website #310
• Profile picture distorted #309
• Implement cachable in models #307
• update #305
• Error with installer - Permission denied #298
• No Staff Groups/ Authorised Permissions #296
• .css and .js 404 #294
• Error on Install #292
• Ability to change interval of cron jobs #289
• ACARS api add response #287
• No bids returned in json #286
• Importing *.csv with special characters #282
• laravel-theme doesn't seem to be respecting the theme.json extends #279
• Flight for current location not being restricted #263
• Self diagnosis #253
• Add /api/pireps/validate endpoint #247
• Cosmetic issues #245
• GDPR Compliance #244
• Read all settings into the page session #243
• Open Airspace #241
• Option to cancel PIREP #238
• Navdata sources #231
• Refactor export, use streamed response #227
• Add expense multiplier to subfleet #206
• Expenses #136
• Finances #130
• phpVMS Classic Importer #114
• Setup cron tasks #95
• Warning in admin if Installer module is still present #77
• flight planning #60

Merged pull requests:

• Merge 7.0.0-beta.2 to master #440
• Refactor the upgrade pending check to see if there are settings/permi… #438
• Fixes #435
• #406 Refactor bids #432
• fixes for issue #419 #429
• Wrap values in travis env #426
• Show a message about setting up the cron and if there was an error ru… #425
• 359 Select theme in settings #423
• Fix blank aircraft field causing error closes #414 #422
• Bundle CSS changes #421
• Some minor CSS fixes as discussed on Discord #420
• Move telemetry option into settings; checkbox in install refs #415 #416
• Issue fixes #413
• Catch error messages in notifying #403
• Design and file upload issues #399
• Don't allow cancels from certain states #396
• Fix map checkout call #394
• 389 API Changes #393
• CSS Libraries and style updates #388
• 384 Laravel 6 changes #385
• 380 vacentral library #381
• Use Notification/Notifiable #379
• Add maintenance section to admin, clear caches #376 #377
• Refactor all JS API calls #360 #375
• Set the baseURL for ajax requests #373
• Move airline transaction code into service layer #371
• 229 url for downloads #369
• #355 Calculate distance button #366
• Add Contract interface for airport lookup functionality #365
• Refactor error handling internally to follow RFC7807 #362
• Additional logging for the stats recalculation #358
• Add missing expiry time for PIREP API #356
• Fix/metar reading #354
• Fix/metar reading #353
• Add setting to include transfer hours in calculations #350
• Remove ext-cal from requirements list #349
• Multiple ticket crash fixes #347
• Issue/327 versioning #345
• Update issue templates #344
• Add step fields to enable decimal points on fields #342 #343
• Issue fixes #341
• Issue/329 refactor seeding #337
• Fix issue where user stats aren't incremented on PIREP auto accept #335
• Account for fuel in the finance calculations #313 #331
• Middleware to detect is update is pending; move Routes into HTTP #328
• Change exporter to use utf-8 close #282 #325
• Rename Interfaces to Contracts to better match Laravel conventions #323
• Cleanup SI Unit classes; METAR fixes #322
• Bump lodash from 4.17.11 to 4.17.13 #321
• Update composer library versions #320
• Add missing folders under storage/public #316 #319
• Add interface to additional roles/permissions #296 #314
• Fix pax count fields; add fuel used field #295 #312
• Apply fixes from StyleCI #311
• Laravel 5.8 Update #308
• Add more search criteria/dev environment via docker-compose #297 #306
• Add gmp to requirements in install #285 #301
• Revert "Update issue templates" #300
• Update issue templates #299

v7.0.0-beta (2018-10-25)

Full Changelog

Implemented enhancements:

• Follow flight checkbox on live map #246
• PIREP restrictions based on settings #221
• Save PIREP as draft #220
• Shorten fields on flights table #205
• Show bids in profile #203
• Don't change rank if current rank is higher than the one found #196
• pagination sizes #162
• Allow overriding templates #161
• Replace old pjax library with newer one #133
• Awards #113
• Setting to restrict airport selection to hubs #104
• Pilot leave status #96
• schedule import #15

Fixed bugs:

• Error saving PIREP #252
• Updater with modules not working #249
• User registration country and timezone not saving #223
• Importer inserts invalid data on empty columns/rows #222
• Import/export - missing fields #219
• Country flag not showing on user list #218
• fares/subfleet unique field blocks saving #214
• module navigation not working (admin) #201
• Bid not removed when pirep if filled #200
• Not saving Flight Time #199

Closed issues:

• SettingsController/Repo are saving as "on" instead of 1/true #272
• Auto Accept New Pilot isn't working #269
• Suggestion: button to copy aircraft #267
• Combine aircraft and subfleet import/export into one #256
• cron - recalculate hours #254
• Install Directory is missing from git repo #251
• Warning: require(C:\xampp\Virtual Airline Website\bootstrap/../vendor/autoload.php): failed to open stream: No such file or directory in C:\xampp\Virtual Airline Website\bootstrap\autoload.php on line 17 #248
• Settings #239
• HTTP caching #237
• Module artisan command bug #234
• Add /api/news #232
• Start date/end date, along with day of week options #230
• Replace weather lookup #228
• File/avatar uploads #226
• Change fleet page to load subfleets first #217
• Add sort options #216
• Auto loader on Line 17 #215
• Add flight fields #213
• Recaptcha in registration #212
• Browser tests #211
• Axios HTTP library #210
• Replace skinning with laravel-theme #209
• Refactor getting expenses in FinanceData #208
• Change all money to hold in cents, not dollars #204
• Pilot pay - rank base and subfleet multiplier #197
• Flight schedule importer/exporter #194
• use find/replace in bootstrapWith() call #163
• Awards #155
• System Changes/Additions #135
• Airport & Aircraft Changes #134
• Handle flight specific fares & multipliers #125
• Flight set day of week #122
• Airport page #85
• Bulk upload charts to airport #84
• Pull some values from existing .env file #79
• METAR Information #61
• flights page #57
• fuel costs to airports and fuel type on subfleet #41
• generate aircraft hex code on create #33

Merged pull requests:

• More acceptable translation to opt-in (es) #284
• Fix 404s to requirements/setup in README.md #283
• Hide expired live flight from live map and remove from DB #280
• [WIP] Laravel 5.7 Update #278
• Make admin input outline darker #276
• capture & display pilot transfer hours #275
• Optimize query with eager loading #274
• Fix SettingsController saving boolean value as 'on' #273
• Hide inactive pilot from pilot list page #271
• Fix flight search restriction #270
• Apply fixes from StyleCI #268
• Fix METAR issue #264
• Apply fixes from StyleCI #262
• Apply fixes from StyleCI #261
• Enable eager loading #259
• Implement cron to remove expired bids #258
• Fix timezone list HTML Escaped #257
• Update 07/13/2018 es-translations #255
• ES translation #250
• flights filtered per va #242
• Avatar Issue #236
• Install bug #235

v7.0.0-alpha2 (2018-02-23)

Full Changelog

Implemented enhancements:

• Get user PIREPs #192
• Use time conversion class #190
• Require inputs in Imperial units #189
• Make planned_distance in prefile optional #185
• If there's no /pirep/route calls, when it's filed, write the route #184
• Create a /api/flight/{id}/route call #183
• Make all APIs behind auth #173
• Add bid #172
• Setting for only showing aircraft that are at the departure airport #171
• Font for input #169
• Read default value from settings table #106

Fixed bugs:

• Volume units to lbs/kg, not gal/liter #193
• Add country to airline missing #191
• SKIN_NAME missing on error pages #187
• Airport timezone not being saved #182
• Rank checkboxes not being saved #181
• Make sure cancelled PIREPs don't show #180
• Ignore cancelled PIREPs in duplicate check #179
• Make sure all fields are returned in PIREP object #178
• autopopulate SOURCE field in ACARS #177
• Make sure pireps.restrict_aircraft_to_rank is respected #170
• Don't change rank if current rank is non-auto promoting #168
• PIREP hours can't be changed #167
• Changing a flight status does not save #150
• Additional PIREP fields don't save correctly #146

Closed issues:

• Cleanup icons #195
• remove raw_data field from pirep table #188
• Remove Resource::withoutWrapping() to follow jsonapi spec #186
• Add an artisan phpvms:dev-install command #176
• Pagination settings #175
• Implement setting for flights at pilot's current airport #174
• Minimum PHP supported version to 7.1 #166
• Update to Laravel 5.6 #165
• Updater #164
• Allow adding rank in subfleet page #160
• Docs #153

v7.0.0-alpha1 (2018-02-04)

Full Changelog

Implemented enhancements:

• Widgetized components #127
• Set aircraft location on landing #112
• save user IP on login #110
• When rejecting PIREP, add a comment/reason #107
• Check for duplicate PIREPs and add setting #105
• create vendor.js with webpack #91
• move from bower to webpack #90
• Pilots list and profile #82
• pirep auto-accept for certain rankings #24
• Investigate removing the Repository pattern to simplify #6

Fixed bugs:

• Error when sending /api/pireps/prefile #149
• Extra numbers on flights page #148
• Unable to select any aircraft from fleet on file PIREP page #147
• Error thrown when editing a saved flight #145
• When you delete flight from admin, filed pirep will throw error #144
• Avoid calling MySQL executable for creating database #132
• Aircraft can be added without specifying a subfleet #128
• Non error flash messages not showing #126
• Removing subfleet from flight #124
• User still has API access if they're not ACTIVE #119
• Delete bids when flight is deleted #103
• JSON error messages #92
• add subfleet to flight broken #88
• logout functionality not working from frontpage #26

Closed issues:

• fuel\_used in pirep/file #159
• Add additional fields for PIREP and flights #158
• Stub file #157
• Add config.php in root on install #156
• New registrations are auto-accepted and put as active #151
• new version alert #143
• Footer copyright text #142
• Version build number to use string/assigned date #141
• Handle duplicate flight number #139
• Restrict shown aircraft to user's rank #138
• Docs #137
• Checksum for tarball #123
• API Items need #120
• ACARS API #118
• List of cron jobs required #117
• Add create/edit fields for columns #111
• Add PIREP cancel endpoint and cleanup job #109
• ACARS table should save the route #102
• /api/fleet and /api/user/fleet #101
• Assign subfleets to ranks #100
• show dates/times in proper timezone #97
• editable fields not working #94
• Settings page needs to be completed #93
• Airport page pagination & search #87
• Mark airport as hub #86
• Terms and Conditions & COPPA during registration #81
• Look at alternative to Entrust #78
• Check if .env file exists in installer #76
• upload travis artifact to phpvms ftp as "latest.zip" #75
• Track hours on airframes #73
• PIREP accept/reject in admin should call PIREP service #72
• Error with MySQL syntax when creating database. #71
• pirep comments #70
• findWithoutFail Method does not exist #69
• Commit error 403 #67
• Keep Showing 404.... #66
• wrap migrate command #65
• Create 404 page #63
• link to admin in nav if you have permissions #62
• Error while creating database #56
• shared hosting stuff #55
• gravatar url for profile #54
• news and notams module #52
• try atoum vs phpunit #51
• Cache Airports calls #49
• add custom fields table for flights #48
• Events system #43
• add fuel costs types to the airports table #40
• adjust "created" date for airline #39
• add gross_weight to PIREPs #38
• subfleet to flight pivot values #37
• API authentication/middleware #36
• REST API #35
• use uuids on a few tables #34
• subfleet (ranks, expenses) #32
• How to install this? #31
• experiment with changing PDO mode #30
• forgot password #27
• rankings #23
• module system #22
• pireps #21
• admin user management #20
• modify DatabaseSeeder to look at env #19
• look at flarum method of install #18
• navdata ingestion #17
• settings panel #16
• routing and scheduling #14
• airport details page #13
• currency format config #12
• aircraft details page #11
• user dashboard and profile pages #10
• admin panel work #9
• theme/skins engine #8
• Integrate roles and permissions #7
• rebuild tables #5
• front-end template #4
• Laravel 5.4 #3
• look up role-based permissions #2
• installer #1

Merged pull requests:

• Fixed a few field entries #116
• Remove unique email entry #115

* This Changelog was automatically generated by github_changelog_generator